tools/clang/plugins/tests/system/windows.h - Issue 1126413004: plugin: Don't warn about inline virtual methods from system macros; whitelist two non-system macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/system/windows.h

Issue 1126413004: plugin: Don't warn about inline virtual methods from system macros; whitelist two non-system macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/plugins/tests/system/windows.h

diff --git a/tools/clang/plugins/tests/system/windows.h b/tools/clang/plugins/tests/system/windows.h

index 66e923de45d5b6bfd6ba9b20728ec8ec6b83349d..98cc307c27957337bf03fe3ba9310b5039a70cba 100644

--- a/tools/clang/plugins/tests/system/windows.h

+++ b/tools/clang/plugins/tests/system/windows.h

@@ -12,4 +12,6 @@

#define SYSTEM_REDUNDANT1 virtual void NonVirtualFinal() final

#define SYSTEM_REDUNDANT2 virtual void Virtual() override final

+#define SYSTEM_INLINE_VIRTUAL virtual int Foo() { return 4; }

#endif // TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_

« no previous file with comments | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/virtual_bodies.h » ('j') | no next file with comments »