Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 1126413002: Handle incoming frames with the same timestamp. (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle incoming frames with the same timestamp. Crash analysis shows frames with the same timestamp getting through. Replaces the old frame if the old frame hasn't yet been rendered or drops the new frame if the old frame has already been shown. BUG=485042 TEST=new unittest. Committed: https://crrev.com/fd4edb8ffe11baf94d554e923b23ca9caefe2d03 Cr-Commit-Position: refs/heads/master@{#328693}

Patch Set 1 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -6 lines) Patch
M media/filters/video_renderer_algorithm.h View 2 chunks +10 lines, -1 line 0 comments Download
M media/filters/video_renderer_algorithm.cc View 3 chunks +22 lines, -5 lines 0 comments Download
M media/filters/video_renderer_algorithm_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
DaleCurtis
5 years, 7 months ago (2015-05-06 23:08:21 UTC) #3
xhwang
lgtm
5 years, 7 months ago (2015-05-07 00:32:25 UTC) #4
DaleCurtis
Thanks for review :)
5 years, 7 months ago (2015-05-07 00:35:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126413002/20001
5 years, 7 months ago (2015-05-07 00:36:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-07 03:42:56 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 03:43:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd4edb8ffe11baf94d554e923b23ca9caefe2d03
Cr-Commit-Position: refs/heads/master@{#328693}

Powered by Google App Engine
This is Rietveld 408576698