Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: cc/test/layer_test_common.cc

Issue 11264056: cc: Use gfx:: Geometry types for positions, bounds, and related things. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ScaleAsVector Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/test/layer_test_common.h ('k') | cc/test/tiled_layer_test_common.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include "cc/test/layer_test_common.h" 7 #include "cc/test/layer_test_common.h"
8 8
9 #include "Region.h"
9 #include "cc/draw_quad.h" 10 #include "cc/draw_quad.h"
10 #include "cc/math_util.h" 11 #include "cc/math_util.h"
12 #include "cc/render_pass.h"
11 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "ui/gfx/rect.h"
15 #include "ui/gfx/point_conversions.h"
16 #include "ui/gfx/rect_conversions.h"
17 #include "ui/gfx/size_conversions.h"
12 18
13 namespace LayerTestCommon { 19 namespace LayerTestCommon {
14 20
15 // Align with expected and actual output 21 // Align with expected and actual output
16 const char* quadString = " Quad: "; 22 const char* quadString = " Quad: ";
17 23
18 bool floatRectCanBeSafelyRoundedToIntRect(const cc::FloatRect& r) 24 bool canRectFBeSafelyRoundedToRect(const gfx::RectF& r)
19 { 25 {
20 // Ensure that range of float values is not beyond integer range. 26 // Ensure that range of float values is not beyond integer range.
21 if (!r.isExpressibleAsIntRect()) 27 if (!cc::FloatRect(r).isExpressibleAsIntRect())
22 return false; 28 return false;
23 29
24 // Ensure that the values are actually integers. 30 // Ensure that the values are actually integers.
25 if (floorf(r.x()) == r.x() 31 if (gfx::ToFlooredPoint(r.origin()) == r.origin()
26 && floorf(r.y()) == r.y() 32 && gfx::ToFlooredSize(r.size()) == r.size())
27 && floorf(r.width()) == r.width()
28 && floorf(r.height()) == r.height())
29 return true; 33 return true;
30 34
31 return false; 35 return false;
32 } 36 }
33 37
34 void verifyQuadsExactlyCoverRect(const cc::QuadList& quads, 38 void verifyQuadsExactlyCoverRect(const cc::QuadList& quads,
35 const cc::IntRect& rect) { 39 const gfx::Rect& rect) {
36 cc::Region remaining(rect); 40 cc::Region remaining = cc::IntRect(rect);
37 41
38 for (size_t i = 0; i < quads.size(); ++i) { 42 for (size_t i = 0; i < quads.size(); ++i) {
39 cc::DrawQuad* quad = quads[i]; 43 cc::DrawQuad* quad = quads[i];
40 cc::FloatRect floatQuadRect = cc::MathUtil::mapClippedRect(quad->sharedQ uadState()->quadTransform, cc::FloatRect(quad->quadRect())); 44 gfx::RectF quadRectF = cc::MathUtil::mapClippedRect(quad->sharedQuadStat e()->quadTransform, gfx::RectF(quad->quadRect()));
41 45
42 // Before testing for exact coverage in the integer world, assert that r ounding 46 // Before testing for exact coverage in the integer world, assert that r ounding
43 // will not round the rect incorrectly. 47 // will not round the rect incorrectly.
44 ASSERT_TRUE(floatRectCanBeSafelyRoundedToIntRect(floatQuadRect)); 48 ASSERT_TRUE(canRectFBeSafelyRoundedToRect(quadRectF));
45 49
46 cc::IntRect quadRect = enclosingIntRect(floatQuadRect); 50 gfx::Rect quadRect = gfx::ToEnclosingRect(quadRectF);
47 51
48 EXPECT_TRUE(rect.contains(quadRect)) << quadString << i; 52 EXPECT_TRUE(rect.Contains(quadRect)) << quadString << i;
49 EXPECT_TRUE(remaining.contains(quadRect)) << quadString << i; 53 EXPECT_TRUE(remaining.contains(cc::IntRect(quadRect))) << quadString << i;
50 remaining.subtract(cc::Region(quadRect)); 54 remaining.subtract(cc::IntRect(quadRect));
51 } 55 }
52 56
53 EXPECT_TRUE(remaining.isEmpty()); 57 EXPECT_TRUE(remaining.isEmpty());
54 } 58 }
55 59
56 } // namespace LayerTestCommon 60 } // namespace LayerTestCommon
OLDNEW
« no previous file with comments | « cc/test/layer_test_common.h ('k') | cc/test/tiled_layer_test_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698