Issue 11264049: PPAPI: Make Messaging not PostTask and copy when out-of-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11264049: PPAPI: Make Messaging not PostTask and copy when out-of-process (Closed)

Created:
8 years, 1 month ago by dmichael (off chromium)

Modified:
8 years ago

Reviewers:
teravest

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI: Make Messaging not PostTask and copy when out-of-process I ran John McCutchan's benchmark (https://github.com/johnmccutchan/NaClComputeEngineBenchmark); this improves the NaCl IPC proxy performance. Without this CL, the benchmark will actually run out of memory and crash on the last test. Results are here: https://docs.google.com/a/google.com/spreadsheet/ccc?key=0AuwLeGmMcfz0dDBXc1dmLUl6Q3dsSW1fUWVZWE5vaHc BUG=147597, 116317 TEST= Closing uncommitted; teravest took over fixing and landing it: https://codereview.chromium.org/11490014/

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -11 lines)			Patch
M	webkit/plugins/ppapi/message_channel.cc	View	3 chunks	+25 lines, -11 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

8 years ago (2012-11-28 15:06:27 UTC) #1

FYI, Justin: I made this a while ago to cut out some overhead that's not
necessary in the new IPC proxy. It fails one of my tests, and I haven't had time
to go back and debug yet, but it might give you an idea where some of the moving
parts of Messaging are.

Expand Messages | Collapse Messages