Set up Android build config.

client/tools/buildbot_annotated_steps.py

Index: client/tools/buildbot_annotated_steps.py
===================================================================
--- client/tools/buildbot_annotated_steps.py	(revision 14040)
+++ client/tools/buildbot_annotated_steps.py	(working copy)
@@ -120,32 +120,19 @@
 
   return subprocess.call(cmds, env=local_env)
 
-def ProcessCompiler(name):
+def ProcessClient(name, client_target):

[Bob Nystrom, 2012/10/25 00:49:16]

"Client" isn't very meaningful, but I like this change. Maybe just a more
generic term like "ProcessBot"?

[Emily Fortuna, 2012/10/25 01:33:34]

Done.

   '''
-  build and test the compiler
+  Build and test the named client target (compiler, android, pub). We look for
+  the supporting script in tools/bots/ to run the tests and build.
   '''
-  print 'ProcessCompiler'
+  print 'Process%s' % client_target.capitalize()
   has_shell=False

[gram, 2012/10/25 00:51:36]

I don't understand why this code is being removed. Is it related to the Android
change?

[Emily Fortuna, 2012/10/25 01:33:34]

This is for refactoring -- as mentioned in the comments on the other side, I'm
accomplishing the same thing but now you just pass in your "target handling
script name" instead of having to rewrite a separate function that simply calls
another python script in the tools/bots directory.

-  if 'windows' in name:
-    # In Windows we need to run in the shell, so that we have all the
-    # environment variables available.
-    has_shell=True
-  return subprocess.call([sys.executable,
-      os.path.join('tools', 'bots', 'compiler.py')],
-      env=os.environ, shell=has_shell)
-
-def ProcessPub(name):
-  '''
-  Build and test pub and the pub packages in the main Dart repository.
-  '''
-  print 'ProcessPub'
-  has_shell=False
   if '-win' in name:
     # In Windows we need to run in the shell, so that we have all the
     # environment variables available.
     has_shell=True
   return subprocess.call([sys.executable,
-      os.path.join('tools', 'bots', 'pub.py')],
+      os.path.join('tools', 'bots', client_target + '.py')],
       env=os.environ, shell=has_shell)
 
 def FixJavaHome():
@@ -223,12 +210,14 @@
     FixJavaHome()
     status = ProcessTools('release', name, version)
   elif name.startswith('pub-'):
-    status = ProcessPub(name)
+    status = ProcessClient(name, 'pub')
+  elif name.startswith('vm-android'):
+    status = ProcessClient(name, 'android')
   else:
     # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart
     # root directory, set JAVA_HOME based on that.
     FixJavaHome()
-    status = ProcessCompiler(name)
+    status = ProcessClient(name, 'compiler')
 
   if status:
     print '@@@STEP_FAILURE@@@'