On active, dismiss the retail mode screensaver immidiately.

On active, dismiss the retail mode screensaver immidiately.
When a user goes active, we try to do the login underneath the screensaver; this has the unfortunate side-effect of it looking like nothing has happened if the login takes too long. Instead, dimiss the screensaver immidiately on the user going active and show a login spinner instead. This indicates clearly to the user that the machine is logging in, instead of not being responsive.

This also removes any need for an observer for SESSION_STARTED since now we aren't waiting for the login to finish to dismiss the screensaver.

TBR'ed jhawkins for gypi change.

R=xiyuan@chromium.org
BUG=157282
TBR=jhawkins@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163942

[xiyuan, 2012-10-24 22:03:19]

http://codereview.chromium.org/11264017/diff/1/chrome/browser/chromeos/kiosk_...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

http://codereview.chromium.org/11264017/diff/1/chrome/browser/chromeos/kiosk_...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:16: #include
"chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
nit: sort alphabetically

http://codereview.chromium.org/11264017/diff/1/chrome/browser/chromeos/kiosk_...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:238:
g_kiosk_mode_screensaver);
There is similar code in KioskModeScreensaver's dtor already. Could we merge it
there?

[rkc, 2012-10-24 22:05:58]

http://codereview.chromium.org/11264017/diff/1/chrome/browser/chromeos/kiosk_...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

http://codereview.chromium.org/11264017/diff/1/chrome/browser/chromeos/kiosk_...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:16: #include
"chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
On 2012/10/24 22:03:19, xiyuan wrote:
> nit: sort alphabetically

Done.

http://codereview.chromium.org/11264017/diff/1/chrome/browser/chromeos/kiosk_...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:238:
g_kiosk_mode_screensaver);
On 2012/10/24 22:03:19, xiyuan wrote:
> There is similar code in KioskModeScreensaver's dtor already. Could we merge
it
> there?

Crap, didn't realize this was already being handled.
Removed the code, the delete will invoke it in the destructor.

Done.

[xiyuan, 2012-10-24 22:07:42]

LGTM

[commit-bot: I haz the power, 2012-10-24 22:10:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/11264017/10001