InvocationMirror implemented in dart2js.

lib/compiler/implementation/js_backend/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
@@ skipping 1248 matching lines @@
       if (compiler.codegenWorld.hasInvokedGetter(member, compiler)) {
         emitDynamicFunctionGetter(member, defineInstanceMember);
       }
     }
   }
 
   void emitNoSuchMethodHandlers(DefineMemberFunction defineInstanceMember) {
     // Do not generate no such method handlers if there is no class.
     if (compiler.codegenWorld.instantiatedClasses.isEmpty) return;
 
-    String noSuchMethodName =
-        namer.publicInstanceMethodNameByArity(Compiler.NO_SUCH_METHOD, 2);
+    String noSuchMethodName = namer.publicInstanceMethodNameByArity(
+        Compiler.NO_SUCH_METHOD, Compiler.NO_SUCH_METHOD_ARG_COUNT);
 
     // Keep track of the JavaScript names we've already added so we
     // do not introduce duplicates (bad for code size).
     Set<String> addedJsNames = new Set<String>();
 
     // Keep track of the noSuchMethod holders for each possible
     // receiver type.
     Map<ClassElement, Set<ClassElement>> noSuchMethodHolders =
         new Map<ClassElement, Set<ClassElement>>();
     Set<ClassElement> noSuchMethodHoldersFor(DartType type) {
       ClassElement element = type.element;
       Set<ClassElement> result = noSuchMethodHolders[element];
       if (result == null) {
         // For now, we check the entire world to see if an object of
         // the given type may have a user-defined noSuchMethod
         // implementation. We could do better by only looking at
         // instantiated (or otherwise needed) classes.
         result = compiler.world.findNoSuchMethodHolders(type);
         noSuchMethodHolders[element] = result;
       }
       return result;
     }
 
     CodeBuffer generateMethod(String methodName, Selector selector) {

[ahe, 2012/10/29 12:14:05]

Could you rename this function while you're at it? This method has a general
name that hides its special purpose.

+      // Values match JSInvocationMirror in js-helper library.
+      const int METHOD = 0;
+      const int GETTER = 1;
+      const int SETTER = 2;
+      int type = METHOD;

[ahe, 2012/10/29 12:14:05]

In a compiler, type means something else. Please find a different name for this
variable, for example, invocationKind.

+      if (selector.isGetter()) {
+        type = GETTER;
+      } else if (selector.isSetter()) {
+        type = SETTER;
+      }
       CodeBuffer args = new CodeBuffer();
       for (int i = 0; i < selector.argumentCount; i++) {
         if (i != 0) args.add(', ');
         args.add('\$$i');
       }
+      CodeBuffer argNames = new CodeBuffer();
+      List<SourceString> names = selector.getOrderedNamedArguments();
+      for (int i = 0; i < names.length; i++) {
+        if (i != 0) argNames.add(', ');
+        argNames.add('"');
+        argNames.add(names[i].slowToString());
+        argNames.add('"');
+      }
+      String internalName = namer.instanceMethodInvocationName(
+          selector.library, new SourceString(methodName), selector);
       CodeBuffer buffer = new CodeBuffer();
       buffer.add('function($args) {\n');
-      buffer.add('  return this.$noSuchMethodName("$methodName", [$args]);\n');
+      buffer.add('  return this.$noSuchMethodName('

[ahe, 2012/10/29 12:14:05]

Notice that $noSuchMethodName is string interpolation. This means that it refers
to the name that is computed on line 1269.

+                     '\$.createInvocationMirror("$methodName", "$internalName",'

[ahe, 2012/10/29 12:14:05]

The same should be done here. The namer needs to have a say in this method name.

+                     ' $type, [$args], [$argNames]));\n');
       buffer.add(' }');
       return buffer;
     }
 
     void addNoSuchMethodHandlers(SourceString ignore, Set<Selector> selectors) {
       // Cache the object class and type.
       ClassElement objectClass = compiler.objectClass;
       DartType objectType = objectClass.computeType(compiler);
 
       for (Selector selector in selectors) {
@@ skipping 265 matching lines @@
 const String HOOKS_API_USAGE = """
 // Generated by dart2js, the Dart to JavaScript compiler.
 // The code supports the following hooks:
 // dartPrint(message)   - if this function is defined it is called
 //                        instead of the Dart [print] method.
 // dartMainRunner(main) - if this function is defined, the Dart [main]
 //                        method will not be invoked directly.
 //                        Instead, a closure that will invoke [main] is
 //                        passed to [dartMainRunner].
 """;