Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 11264: Drop Set-Cookie from XHR response headers (Closed)

Created:
12 years, 1 month ago by mschilder
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a third flavor to response header persistence. XMLHttpRequest response headers should not contain Set-Cookie or Set-Cookie2 headers.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -61 lines) Patch
M chrome/common/render_messages.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -2 lines 0 comments Download
M net/http/http_cache.cc View 1 2 3 4 5 1 chunk +12 lines, -1 line 0 comments Download
M net/http/http_response_headers.h View 1 2 3 4 5 2 chunks +26 lines, -8 lines 0 comments Download
M net/http/http_response_headers.cc View 1 2 3 4 5 6 4 chunks +72 lines, -37 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 2 3 4 5 12 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Dean McNamee
Just skimmed it, looks really good over all. Removing the true / false parameter is ...
12 years, 1 month ago (2008-11-19 17:04:59 UTC) #1
darin (slow to review)
Do we need this change given: http://trac.webkit.org/changeset/38566 https://bugs.webkit.org/show_bug.cgi?id=10957 http://codereview.chromium.org/11264/diff/1/5 File net/http/http_response_headers.h (right): http://codereview.chromium.org/11264/diff/1/5#newcode50 Line 50: ...
12 years, 1 month ago (2008-11-19 17:11:37 UTC) #2
Dean McNamee
http://codereview.chromium.org/11264/diff/1/4 File net/http/http_response_headers.cc (right): http://codereview.chromium.org/11264/diff/1/4#newcode110 Line 110: GetNonIPCHeaders(&filtered_headers); I guess now this should be GetCookieHeaders, ...
12 years, 1 month ago (2008-11-19 17:34:50 UTC) #3
Dean McNamee
Looks better, still some nits. It's up to Darin on the real code. http://codereview.chromium.org/11264/diff/408/18 File ...
12 years, 1 month ago (2008-11-19 22:13:38 UTC) #4
mschilder
On 2008/11/19 22:13:38, Dean McNamee wrote: > Looks better, still some nits. It's up to ...
12 years, 1 month ago (2008-11-19 22:29:38 UTC) #5
mschilder
On 2008/11/19 17:11:37, darin wrote: > Do we need this change given: > http://trac.webkit.org/changeset/38566 > ...
12 years, 1 month ago (2008-11-19 22:30:27 UTC) #6
Dean McNamee
Style wise looks ok by me. Darin on the rest. http://codereview.chromium.org/11264/diff/412/416 File net/http/http_response_headers.h (right): http://codereview.chromium.org/11264/diff/412/416#newcode257 ...
12 years, 1 month ago (2008-11-19 22:32:42 UTC) #7
darin (slow to review)
http://codereview.chromium.org/11264/diff/411/23 File net/http/http_response_headers.h (right): http://codereview.chromium.org/11264/diff/411/23#newcode50 Line 50: PERSIST_WITHOUT_SENSITIVE_HEADERS = 2, hmm... vaguely naming this seems ...
12 years, 1 month ago (2008-11-19 22:35:42 UTC) #8
mschilder
On 2008/11/19 22:32:42, Dean McNamee wrote: > Style wise looks ok by me. Darin on ...
12 years, 1 month ago (2008-11-19 22:40:25 UTC) #9
mschilder
On 2008/11/19 22:35:42, darin wrote: > http://codereview.chromium.org/11264/diff/411/23 > File net/http/http_response_headers.h (right): > > http://codereview.chromium.org/11264/diff/411/23#newcode50 > ...
12 years, 1 month ago (2008-11-20 02:37:50 UTC) #10
darin (slow to review)
12 years, 1 month ago (2008-11-20 03:50:17 UTC) #11
LGTM !

Powered by Google App Engine
This is Rietveld 408576698