Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1126393006: core_services: Run different services in different processes. (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core_services: Run different services in different processes. When mandoline is run with --enable-multiprocess, we should run some services in different processes. This reuses |qualifier| in Identity (which is already used for content handlers that need to run in different contexts) to be a process name in contexts where there is a package alias. This places mojo:network_services in its own process, and everything else in a different process. When run without --enable-multiprocess, this change is a noop. BUG=477435 Committed: https://crrev.com/88221a5c027ab748c0bca451736c398098d125d2 Cr-Commit-Position: refs/heads/master@{#329421}

Patch Set 1 #

Patch Set 2 : Fix unit tests by never having an empty qualifier. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -59 lines) Patch
M mandoline/app/core_services_initialization.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/runner/context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/runner/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/shell/application_manager.h View 6 chunks +16 lines, -5 lines 0 comments Download
M mojo/shell/application_manager.cc View 17 chunks +72 lines, -41 lines 0 comments Download
M mojo/shell/identity.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
5 years, 7 months ago (2015-05-12 00:27:54 UTC) #2
jam
lgtm
5 years, 7 months ago (2015-05-12 15:52:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126393006/20001
5 years, 7 months ago (2015-05-12 16:40:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 16:44:57 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:46:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88221a5c027ab748c0bca451736c398098d125d2
Cr-Commit-Position: refs/heads/master@{#329421}

Powered by Google App Engine
This is Rietveld 408576698