Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1126393005: Fix java handler. (Closed)

Created:
5 years, 7 months ago by qsr
Modified:
5 years, 7 months ago
Reviewers:
blundell
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix java handler. The java handler expects a Mojo-Class entry in the manifest of the application. The latest dx tool strip the manifest to its bare minimum and removed everything we added. This change the build system to add the entry to the manifest after running dx. R=blundell@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9df4d8e03991ea837b090bb7ce8f6fbdff849c53

Patch Set 1 #

Total comments: 6

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -3 lines) Patch
A services/android/add_manifest_entry.py View 1 1 chunk +54 lines, -0 lines 0 comments Download
M services/android/rules.gni View 1 4 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qsr
5 years, 7 months ago (2015-05-11 14:40:18 UTC) #1
blundell
lgtm https://codereview.chromium.org/1126393005/diff/1/services/android/add_manifest_entry.py File services/android/add_manifest_entry.py (right): https://codereview.chromium.org/1126393005/diff/1/services/android/add_manifest_entry.py#newcode7 services/android/add_manifest_entry.py:7: """Add an entry into the manigest file of ...
5 years, 7 months ago (2015-05-11 14:49:14 UTC) #2
qsr
Committed patchset #2 (id:20001) manually as 9df4d8e03991ea837b090bb7ce8f6fbdff849c53 (presubmit successful).
5 years, 7 months ago (2015-05-11 14:54:52 UTC) #3
qsr
5 years, 7 months ago (2015-05-11 14:56:27 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1126393005/diff/1/services/android/add_manife...
File services/android/add_manifest_entry.py (right):

https://codereview.chromium.org/1126393005/diff/1/services/android/add_manife...
services/android/add_manifest_entry.py:7: """Add an entry into the manigest file
of a jar file."""
On 2015/05/11 14:49:13, blundell wrote:
> nit: s/manigest/manifest everywhere (including cl description)

Done.

https://codereview.chromium.org/1126393005/diff/1/services/android/rules.gni
File services/android/rules.gni (left):

https://codereview.chromium.org/1126393005/diff/1/services/android/rules.gni#...
services/android/rules.gni:27: manifest_entries = [ "Mojo-Class:" +
invoker.mojo_main ]
On 2015/05/11 14:49:14, blundell wrote:
> is there still a point to this?

Removed

https://codereview.chromium.org/1126393005/diff/1/services/android/rules.gni
File services/android/rules.gni (right):

https://codereview.chromium.org/1126393005/diff/1/services/android/rules.gni#...
services/android/rules.gni:8: servicess_android_path = get_path_info(".",
"abspath")
On 2015/05/11 14:49:14, blundell wrote:
> hmm, if this is intended to be available to consumers it should be in
> //mojo/services/android/public instead (pre-existing issue not to be fixed in
> this cl obviously).

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698