Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1126383005: [Android WebView] Send WebChromeClient.onReceivedTitle when navigating back (Closed)

Created:
5 years, 7 months ago by mnaganov (inactive)
Modified:
5 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Send WebChromeClient.onReceivedTitle when navigating back The usual channel for delivering onReceivedTitle (via updating title for a NavigationEntry) doesn't work in the case of history navigations, because WebContentsImpl silences no-op updates of entries titles. Chrome Browser uses another event for updating the title in this case -- via WebContentsDelegate::LoadingStateChanged. This patch enables WebView to use it as well. Note that WebChromeClient.onReceivedIcon doesn't need to be re-sent, as nobody seems to bother checking whether the icon update is a "no-op", so updates on history navigations just work. BUG=481570 Committed: https://crrev.com/38d1092ea27df0818a8a20b114fcf0cac9018a68 Cr-Commit-Position: refs/heads/master@{#329408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java View 1 chunk +19 lines, -0 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
5 years, 7 months ago (2015-05-12 00:21:28 UTC) #2
Torne
lgtm
5 years, 7 months ago (2015-05-12 10:35:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126383005/1
5 years, 7 months ago (2015-05-12 14:14:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 15:07:27 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 15:08:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38d1092ea27df0818a8a20b114fcf0cac9018a68
Cr-Commit-Position: refs/heads/master@{#329408}

Powered by Google App Engine
This is Rietveld 408576698