Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1126383003: Add strings for webstore widget app (Closed)

Created:
5 years, 7 months ago by tbarzic
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add strings for webstore widget app BUG=477106 Committed: https://crrev.com/c5965213578a7f6f6ce3e038e4283363673944a2 Cr-Commit-Position: refs/heads/master@{#329490}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc View 1 2 2 chunks +27 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tbarzic
5 years, 7 months ago (2015-05-08 22:35:29 UTC) #2
yoshiki
lgtm
5 years, 7 months ago (2015-05-12 06:42:16 UTC) #3
tbarzic
+asargent for component_loader.cc
5 years, 7 months ago (2015-05-12 17:05:17 UTC) #5
asargent_no_longer_on_chrome
lgtm
5 years, 7 months ago (2015-05-12 19:42:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126383003/40001
5 years, 7 months ago (2015-05-12 19:56:55 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 21:13:24 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 21:14:26 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c5965213578a7f6f6ce3e038e4283363673944a2
Cr-Commit-Position: refs/heads/master@{#329490}

Powered by Google App Engine
This is Rietveld 408576698