chrome/browser/download/notification/download_notification_item.h - Issue 1126343006: Open the learn more page when user clicks a notification of malicious download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_notification_item.h

Issue 1126343006: Open the learn more page when user clicks a notification of malicious download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/notification/download_notification_item.h

diff --git a/chrome/browser/download/notification/download_notification_item.h b/chrome/browser/download/notification/download_notification_item.h

index 48ac18b5372f07a834c49858080f07d318aace1c..76fb48b9e5a7e4c9d8b96d5f6850b98f4ec504be 100644

--- a/chrome/browser/download/notification/download_notification_item.h

+++ b/chrome/browser/download/notification/download_notification_item.h

@@ -102,9 +102,9 @@ class DownloadNotificationItem : public content::DownloadItem::Observer {

Browser* GetBrowser();

- scoped_ptr<std::vector<DownloadCommands::Command>> GetPossibleActions() const;

+ // Returns the list of possible extra (all except the default) actions.

+ scoped_ptr<std::vector<DownloadCommands::Command>> GetExtraActions() const;

- bool openable_ = false;

int image_resource_id_ = 0;

content::DownloadItem::DownloadState previous_download_state_ =

content::DownloadItem::MAX_DOWNLOAD_STATE; // As uninitialized state

« no previous file with comments | « no previous file | chrome/browser/download/notification/download_notification_item.cc » ('j') | no next file with comments »