Open the learn more page when user clicks a notification of malicious download

chrome/browser/download/notification/download_notification_item.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/notification/download_notification_item.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_item_model.h"
@@ skipping 94 matching lines @@
 
   UpdateNotificationData(ADD_NEW);
 }
 
 DownloadNotificationItem::~DownloadNotificationItem() {
   if (item_)
     item_->RemoveObserver(this);
 }
 
 void DownloadNotificationItem::OnNotificationClick() {
-  if (openable_) {
-    if (item_->IsDone()) {
+  if (item_->IsDangerous()) {
+#if defined(FULL_SAFE_BROWSING)
+    DownloadCommands(item_).ExecuteCommand(
+        DownloadCommands::LEARN_MORE_SCANNING);
+#else
+    CloseNotificationByUser();
+#endif
+    return;
+  }
+
+  switch (item_->GetState()) {
+    case content::DownloadItem::IN_PROGRESS:
+      item_->SetOpenWhenComplete(!item_->GetOpenWhenComplete());  // Toggle
+      break;
+    case content::DownloadItem::CANCELLED:
+    case content::DownloadItem::INTERRUPTED:
+      GetBrowser()->OpenURL(content::OpenURLParams(
+          GURL(chrome::kChromeUIDownloadsURL), content::Referrer(),
+          NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,
+          false /* is_renderer_initiated */));
+      CloseNotificationByUser();
+      break;
+    case content::DownloadItem::COMPLETE:
       item_->OpenDownload();
       CloseNotificationByUser();
-    } else {
-      item_->SetOpenWhenComplete(!item_->GetOpenWhenComplete());  // Toggle
-    }
-  } else if (item_->GetState() == content::DownloadItem::INTERRUPTED ||
-             item_->GetState() == content::DownloadItem::CANCELLED) {
-    GetBrowser()->OpenURL(content::OpenURLParams(
-        GURL(chrome::kChromeUIDownloadsURL), content::Referrer(),
-        NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,
-        false /* is_renderer_initiated */));
-    CloseNotificationByUser();
-  } else if (item_->IsDone()) {
-    CloseNotificationByUser();
+      break;
+    case content::DownloadItem::MAX_DOWNLOAD_STATE:
+      NOTREACHED();
   }
 }
 
 void DownloadNotificationItem::OnNotificationButtonClick(int button_index) {
   if (button_index < 0 ||
       static_cast<size_t>(button_index) >= button_actions_->size()) {
     // Out of boundary.
     NOTREACHED();
     return;
   }
@@ skipping 118 matching lines @@
         notification_->set_progress(0);
         SetNotificationImage(IDR_DOWNLOAD_NOTIFICATION_WARNING);
         break;
       case content::DownloadItem::MAX_DOWNLOAD_STATE:  // sentinel
         NOTREACHED();
     }
   }
 
   std::vector<message_center::ButtonInfo> notification_actions;
   scoped_ptr<std::vector<DownloadCommands::Command>> actions(
-      GetPossibleActions().Pass());
+      GetExtraActions().Pass());
 
-  openable_ = false;
   button_actions_.reset(new std::vector<DownloadCommands::Command>);
   for (auto it = actions->begin(); it != actions->end(); it++) {
-    if (*it == DownloadCommands::OPEN_WHEN_COMPLETE) {
-      openable_ = true;
-    } else {
-      button_actions_->push_back(*it);
-      message_center::ButtonInfo button_info =
-          message_center::ButtonInfo(GetCommandLabel(*it));
-      button_info.icon = command.GetCommandIcon(*it);
-      notification_actions.push_back(button_info);
-    }
+    button_actions_->push_back(*it);
+    message_center::ButtonInfo button_info =
+        message_center::ButtonInfo(GetCommandLabel(*it));
+    button_info.icon = command.GetCommandIcon(*it);
+    notification_actions.push_back(button_info);
   }
   notification_->set_buttons(notification_actions);
 
   if (item_->IsDone()) {
     // TODO(yoshiki): If the downloaded file is an image, show the thumbnail.
   }
 
   if (type == ADD_NEW) {
     notification_ui_manager()->Add(*notification_, profile_);
   } else if (type == UPDATE_EXISTING) {
@@ skipping 48 matching lines @@
 
 NotificationUIManager* DownloadNotificationItem::notification_ui_manager()
     const {
   if (stub_notification_ui_manager_for_testing_) {
     return stub_notification_ui_manager_for_testing_;
   }
   return g_browser_process->notification_ui_manager();
 }
 
 scoped_ptr<std::vector<DownloadCommands::Command>>
-DownloadNotificationItem::GetPossibleActions() const {
+DownloadNotificationItem::GetExtraActions() const {
   scoped_ptr<std::vector<DownloadCommands::Command>> actions(
       new std::vector<DownloadCommands::Command>());
 
   if (item_->IsDangerous()) {
     actions->push_back(DownloadCommands::DISCARD);
     actions->push_back(DownloadCommands::KEEP);
     return actions.Pass();
   }
 
   switch (item_->GetState()) {
     case content::DownloadItem::IN_PROGRESS:
-      actions->push_back(DownloadCommands::OPEN_WHEN_COMPLETE);
       if (!item_->IsPaused())
         actions->push_back(DownloadCommands::PAUSE);
       else
         actions->push_back(DownloadCommands::RESUME);
       actions->push_back(DownloadCommands::CANCEL);
       break;
     case content::DownloadItem::CANCELLED:
     case content::DownloadItem::INTERRUPTED:
       if (item_->CanResume())
         actions->push_back(DownloadCommands::RESUME);
       break;
     case content::DownloadItem::COMPLETE:
-      actions->push_back(DownloadCommands::OPEN_WHEN_COMPLETE);
       actions->push_back(DownloadCommands::SHOW_IN_FOLDER);
       break;
     case content::DownloadItem::MAX_DOWNLOAD_STATE:
       NOTREACHED();
   }
   return actions.Pass();
 }
 
 base::string16 DownloadNotificationItem::GetTitle() const {
   base::string16 title_text;
@@ skipping 105 matching lines @@
   NOTREACHED();
   return base::string16();
 }
 
 Browser* DownloadNotificationItem::GetBrowser() {
   chrome::ScopedTabbedBrowserDisplayer browser_displayer(
       profile_, chrome::GetActiveDesktop());
   DCHECK(browser_displayer.browser());
   return browser_displayer.browser();
 }