Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: Source/core/frame/SubresourceIntegrity.h

Issue 1126343003: Ignore unknown options to subresource integrity (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed some edge cases Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/SubresourceIntegrity.h
diff --git a/Source/core/frame/SubresourceIntegrity.h b/Source/core/frame/SubresourceIntegrity.h
index 49fa4c623dafe62249d041293381b88429a36f6f..30718dcebb30cd015a72accd9bdd023e02779870 100644
--- a/Source/core/frame/SubresourceIntegrity.h
+++ b/Source/core/frame/SubresourceIntegrity.h
@@ -26,7 +26,7 @@ public:
IntegrityParseNoValidResult
};
- static bool CheckSubresourceIntegrity(const Element&, const WTF::String& content, const KURL& resourceUrl, const WTF::String& mimeType, const Resource&);
+ static bool CheckSubresourceIntegrity(const Element&, const WTF::String& content, const KURL& resourceUrl, const Resource&);
private:
// FIXME: After the merge with the Chromium repo, this should be refactored
@@ -44,12 +44,11 @@ private:
struct IntegrityMetadata {
WTF::String digest;
HashAlgorithm algorithm;
- WTF::String type;
};
static AlgorithmParseResult parseAlgorithm(const UChar*& begin, const UChar* end, HashAlgorithm&);
static bool parseDigest(const UChar*& begin, const UChar* end, String& digest);
- static bool parseMimeType(const UChar*& begin, const UChar* end, String& type);
+ static bool parseOption(const UChar*& begin, const UChar* end, String& name, String& value);
static IntegrityParseResult parseIntegrityAttribute(const WTF::String& attribute, WTF::Vector<IntegrityMetadata>& metadataList, Document&);
};

Powered by Google App Engine
This is Rietveld 408576698