Source/core/frame/SubresourceIntegrity.h - Issue 1126343003: Ignore unknown options to subresource integrity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/SubresourceIntegrity.h

Issue 1126343003: Ignore unknown options to subresource integrity (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/SubresourceIntegrity.h

diff --git a/Source/core/frame/SubresourceIntegrity.h b/Source/core/frame/SubresourceIntegrity.h

index 49fa4c623dafe62249d041293381b88429a36f6f..2ea981628532f32cc9d4d776bfd4d2f94ff40d81 100644

--- a/Source/core/frame/SubresourceIntegrity.h

+++ b/Source/core/frame/SubresourceIntegrity.h

@@ -49,7 +49,8 @@ private:

static AlgorithmParseResult parseAlgorithm(const UChar*& begin, const UChar* end, HashAlgorithm&);

static bool parseDigest(const UChar*& begin, const UChar* end, String& digest);

- static bool parseMimeType(const UChar*& begin, const UChar* end, String& type);

+ static bool parseOption(const UChar*& begin, const UChar* end, String& name, String& value);

+ static bool isValidMimeTypeValue(const String& value);

static IntegrityParseResult parseIntegrityAttribute(const WTF::String& attribute, WTF::Vector<IntegrityMetadata>& metadataList, Document&);

};