Issue 1126333006: [Effen] Make the drawer not be included in the build output when the drawer is not shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1126333006: [Effen] Make the drawer not be included in the build output when the drawer is not shown. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

[Effen] Make the drawer not be included in the build output when the drawer is not shown. This is a prerequisite to dropping 'display:none'. Included in this CL is making AnimatedValue able to animate more than one field. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/678ead5cb86289a07ffd675ba293c7fdebb1ef40

Patch Set 1 #

Total comments: 1

Patch Set 2 : git cl land #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -15 lines)			Patch
M	sky/examples/stocks/lib/stock_app.dart	View	1	5 chunks	+16 lines, -5 lines	0 comments	Download
M	sky/framework/animation/animated_value.dart	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	sky/framework/components/animated_component.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	sky/framework/components/drawer.dart	View		4 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1126333006/diff/1/sky/examples/stocks/lib/stock_app.dart File sky/examples/stocks/lib/stock_app.dart (right): https://codereview.chromium.org/1126333006/diff/1/sky/examples/stocks/lib/stock_app.dart#newcode50 sky/examples/stocks/lib/stock_app.dart:50: _drawerController = new DrawerController(_handleDrawerStatusChanged);; Extra ; here

5 years, 7 months ago (2015-05-14 16:33:32 UTC) #2

Hixie

5 years, 7 months ago (2015-05-14 16:44:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
678ead5cb86289a07ffd675ba293c7fdebb1ef40 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages