Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 112633007: Adjust ChromeVox notification strings. (Closed)

Created:
6 years, 11 months ago by David Tseng
Modified:
6 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Adjust ChromeVox notification strings. BUG=261451 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243237

Patch Set 1 #

Total comments: 1

Patch Set 2 : Lowercase "Spoken" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/ash_strings.grd View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
David Tseng
6 years, 11 months ago (2014-01-06 19:52:47 UTC) #1
James Cook
LGTM with question about capitalization https://codereview.chromium.org/112633007/diff/1/ash/ash_strings.grd File ash/ash_strings.grd (right): https://codereview.chromium.org/112633007/diff/1/ash/ash_strings.grd#newcode212 ash/ash_strings.grd:212: ChromeVox (Spoken feedback) is ...
6 years, 11 months ago (2014-01-06 20:22:57 UTC) #2
David Tseng
On Mon, Jan 6, 2014 at 12:22 PM, <jamescook@chromium.org> wrote: > LGTM with question about ...
6 years, 11 months ago (2014-01-06 20:35:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/112633007/50001
6 years, 11 months ago (2014-01-06 20:36:59 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 10:08:56 UTC) #5
Message was sent while issue was closed.
Change committed as 243237

Powered by Google App Engine
This is Rietveld 408576698