Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1126323003: WindowManager now can handle URL intents on Android (Closed)

Created:
5 years, 7 months ago by Jay Civelli
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: WindowManager now can handle URL intents on Android Passing down the URL parameters given to the MojoShellActivity from the intent and making it handle HTTP/HTTPS URLs. BUG=None Committed: https://crrev.com/4313b5b899dc48e3a89735deb82596d6983c21ba Cr-Commit-Position: refs/heads/master@{#330189}

Patch Set 1 #

Patch Set 2 : Fixing presubmit errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M mandoline/app/android/apk/AndroidManifest.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 1 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Jay Civelli
5 years, 7 months ago (2015-05-15 00:04:34 UTC) #2
sky
Nice, LGTM
5 years, 7 months ago (2015-05-15 00:52:29 UTC) #3
Ben Goodger (Google)
lgtm2
5 years, 7 months ago (2015-05-15 02:07:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126323003/1
5 years, 7 months ago (2015-05-15 17:21:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64034)
5 years, 7 months ago (2015-05-15 17:28:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126323003/20001
5 years, 7 months ago (2015-05-15 20:11:47 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 20:48:44 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:10 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4313b5b899dc48e3a89735deb82596d6983c21ba
Cr-Commit-Position: refs/heads/master@{#330189}

Powered by Google App Engine
This is Rietveld 408576698