Make one copy for all TypedArray methods

Make one copy for all TypedArray methods

This is the first step of converting TypedArrays to the proper
proto chain. There is one copy for each of the Harmony TypedArray
methods, rather than a version for each TypedArray type. This
form prevents accidentally baking in knowledge about a particular
array type into the method definition.

R=adamk@chromium.org, arv@chromium.org, caitpotter88@gmail.com, dslomov@chromium.org, jochen@chromium.org
BUG=v8:4085
LOG=Y

Committed: https://crrev.com/ca9d499f75b3557840f82f1ad172afdb514ce2d1
Cr-Commit-Position: refs/heads/master@{#28325}

[adamk, 2015-05-07 20:09:05]

Please add a test for this enforcing that there is but a single one of each of
these functions on all TypedArray prototypes (could make this a data-driven test
that exhaustively tests all TypedArray subtypes and each method).

[dehrenberg, 2015-05-08 01:08:08]

Done

[adamk, 2015-05-08 01:13:34]

https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js
File src/typedarray.js (right):

https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js#newco...
src/typedarray.js:158: function TypedArraySubArray(begin, end) {
We probably want to change this in the future, but I'd like to limit the changes
you're making in this one to what's behind the --harmony-arrays flag (and thus
won't affect what we're currently shipping).

https://codereview.chromium.org/1126313003/diff/40001/test/mjsunit/harmony/ty...
File test/mjsunit/harmony/typedarray-proto.js (right):

https://codereview.chromium.org/1126313003/diff/40001/test/mjsunit/harmony/ty...
test/mjsunit/harmony/typedarray-proto.js:1: // Copyright 2014 the V8 project
authors. All rights reserved.
Nit: update date to 2015 when adding new tests

https://codereview.chromium.org/1126313003/diff/40001/test/mjsunit/harmony/ty...
test/mjsunit/harmony/typedarray-proto.js:5: // Flags: --harmony-arrays
--harmony_arrow_functions
Arrow functions aren't far enough along to be relied upon in tests yet, please
only use flags to turn on features you're testing directly.

[dehrenberg, 2015-05-08 19:46:06]

On 2015/05/08 01:13:34, adamk wrote:
> https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js
> File src/typedarray.js (right):
> 
>
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js#newco...
> src/typedarray.js:158: function TypedArraySubArray(begin, end) {
> We probably want to change this in the future, but I'd like to limit the
changes
> you're making in this one to what's behind the --harmony-arrays flag (and thus
> won't affect what we're currently shipping).
Done. When do you think we'd be ready for the full change--immediately after
this, or with some more testing included?
> 
>
https://codereview.chromium.org/1126313003/diff/40001/test/mjsunit/harmony/ty...
> File test/mjsunit/harmony/typedarray-proto.js (right):
> 
>
https://codereview.chromium.org/1126313003/diff/40001/test/mjsunit/harmony/ty...
> test/mjsunit/harmony/typedarray-proto.js:1: // Copyright 2014 the V8 project
> authors. All rights reserved.
> Nit: update date to 2015 when adding new tests
Done
> 
>
https://codereview.chromium.org/1126313003/diff/40001/test/mjsunit/harmony/ty...
> test/mjsunit/harmony/typedarray-proto.js:5: // Flags: --harmony-arrays
> --harmony_arrow_functions
> Arrow functions aren't far enough along to be relied upon in tests yet, please
> only use flags to turn on features you're testing directly.
Done

[arv (Not doing code reviews), 2015-05-08 20:02:03]

https://codereview.chromium.org/1126313003/diff/60001/test/mjsunit/harmony/ty...
File test/mjsunit/harmony/typedarray-proto.js (right):

https://codereview.chromium.org/1126313003/diff/60001/test/mjsunit/harmony/ty...
test/mjsunit/harmony/typedarray-proto.js:40:
typedArrayConstructors.map(function(constructor) {
maybe a nested loop would be cleaner?

for (var method of typedArrayMethods) {
  for (var constructor of typedArrayConstructors) {
    assertEqual(Uint8Array.prototype[method],
                constructor.prototype[method]);
  }
}

[adamk, 2015-05-08 20:07:42]

lgtm % arv's comments

On 2015/05/08 19:46:06, dehrenberg wrote:
> On 2015/05/08 01:13:34, adamk wrote:
> > https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js
> > File src/typedarray.js (right):
> > 
> >
>
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js#newco...
> > src/typedarray.js:158: function TypedArraySubArray(begin, end) {
> > We probably want to change this in the future, but I'd like to limit the
> changes
> > you're making in this one to what's behind the --harmony-arrays flag (and
thus
> > won't affect what we're currently shipping).
> Done. When do you think we'd be ready for the full change--immediately after
> this, or with some more testing included?

I'd almost rather leave it for much later, maybe when we turn on the
--harmony-arrays flag by default. The advantage of doing that is that no
behavior changes until all the behavior does. But I guess that depends on how
you're planning on adding the new prototype object. arv, any thoughts on compat
risk here? I'm probably just being too paranoid.

[dehrenberg, 2015-05-08 20:57:00]

The CQ bit was checked by dehrenberg@chromium.org

[dehrenberg, 2015-05-08 20:57:01]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1126313003/#ps80001
(title: "Cleaner tests")

[commit-bot: I haz the power, 2015-05-08 20:57:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126313003/80001

[commit-bot: I haz the power, 2015-05-09 01:20:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-09 01:20:22]

Patchset 5 (id:??) landed as
https://crrev.com/ca9d499f75b3557840f82f1ad172afdb514ce2d1
Cr-Commit-Position: refs/heads/master@{#28325}