Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Unified Diff: runtime/bin/http_impl.dart

Issue 11263040: Make String.charCodes a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status files with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/intl/lib/number_format.dart ('k') | runtime/bin/mime_multipart_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/http_impl.dart
diff --git a/runtime/bin/http_impl.dart b/runtime/bin/http_impl.dart
index f90339d6565176278612ba8f4200669920ed90b9..557ea09b2e345bfe0069120613fd6e85a88c0aa7 100644
--- a/runtime/bin/http_impl.dart
+++ b/runtime/bin/http_impl.dart
@@ -252,7 +252,7 @@ class _HttpHeaders implements HttpHeaders {
_headers.forEach((String name, List<String> values) {
bool fold = _foldHeader(name);
List<int> data;
- data = name.charCodes();
+ data = name.charCodes;
connection._write(data);
connection._write(COLONSP);
for (int i = 0; i < values.length; i++) {
@@ -261,12 +261,12 @@ class _HttpHeaders implements HttpHeaders {
connection._write(COMMASP);
} else {
connection._write(CRLF);
- data = name.charCodes();
+ data = name.charCodes;
connection._write(data);
connection._write(COLONSP);
}
}
- data = values[i].charCodes();
+ data = values[i].charCodes;
connection._write(data);
}
connection._write(CRLF);
@@ -1110,10 +1110,10 @@ class _HttpResponse extends _HttpRequestResponseBase implements HttpResponse {
_httpConnection._write(_Const.HTTP10);
}
_writeSP();
- data = _statusCode.toString().charCodes();
+ data = _statusCode.toString().charCodes;
_httpConnection._write(data);
_writeSP();
- data = reasonPhrase.charCodes();
+ data = reasonPhrase.charCodes;
_httpConnection._write(data);
_writeCRLF();
@@ -1669,7 +1669,7 @@ class _HttpClientRequest
List<int> data;
// Write request line.
- data = _method.toString().charCodes();
+ data = _method.toString().charCodes;
_httpConnection._write(data);
_writeSP();
// Send the path for direct connections and the whole URL for
@@ -1684,9 +1684,9 @@ class _HttpClientRequest
path = "${path}?${_uri.query}";
}
}
- data = path.charCodes();
+ data = path.charCodes;
} else {
- data = _uri.toString().charCodes();
+ data = _uri.toString().charCodes;
}
_httpConnection._write(data);
_writeSP();
« no previous file with comments | « pkg/intl/lib/number_format.dart ('k') | runtime/bin/mime_multipart_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698