Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: utils/apidoc/apidoc.dart

Issue 11263020: Fixes documentation generation for dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/apidoc/apidoc.dart
diff --git a/utils/apidoc/apidoc.dart b/utils/apidoc/apidoc.dart
index 51ea88bdbd6924fc4b3b740a17ea489d80fc91b8..eac8037cb5d17b2f849b4b59b1a0f0da36813dd9 100644
--- a/utils/apidoc/apidoc.dart
+++ b/utils/apidoc/apidoc.dart
@@ -179,7 +179,7 @@ class Htmldoc extends doc.Dartdoc {
}
doc.DocComment getRecordedLibraryComment(LibraryMirror library) {
- if (library.simpleName == HTML_LIBRARY_NAME) {
+ if (doc.printedName(library) == HTML_LIBRARY_NAME) {
return libraryComment;
}
return null;
@@ -351,21 +351,21 @@ class Apidoc extends doc.Dartdoc {
void docIndexLibrary(LibraryMirror library) {
// TODO(rnystrom): Hackish. The IO libraries reference this but we don't
// want it in the docs.
- if (library.simpleName == 'dart:nativewrappers') return;
+ if (doc.printedName(library)== 'dart:nativewrappers') return;
Bob Nystrom 2012/10/24 20:52:15 Space before "==" here and elsewhere.
Andrei Mouravski 2012/10/24 21:19:36 Done.
super.docIndexLibrary(library);
}
void docLibraryNavigationJson(LibraryMirror library, List libraryList) {
// TODO(rnystrom): Hackish. The IO libraries reference this but we don't
// want it in the docs.
- if (library.simpleName == 'dart:nativewrappers') return;
+ if (doc.printedName(library)== 'dart:nativewrappers') return;
super.docLibraryNavigationJson(library, libraryList);
}
void docLibrary(LibraryMirror library) {
// TODO(rnystrom): Hackish. The IO libraries reference this but we don't
// want it in the docs.
- if (library.simpleName == 'dart:nativewrappers') return;
+ if (doc.printedName(library)== 'dart:nativewrappers') return;
super.docLibrary(library);
}
@@ -380,7 +380,7 @@ class Apidoc extends doc.Dartdoc {
}
doc.DocComment getLibraryComment(LibraryMirror library) {
- if (library.simpleName == HTML_LIBRARY_NAME) {
+ if (doc.printedName(library)== HTML_LIBRARY_NAME) {
return htmldoc.libraryComment;
}
return super.getLibraryComment(library);
@@ -460,7 +460,7 @@ class Apidoc extends doc.Dartdoc {
}
var typeString = '';
- if (type.library.simpleName == HTML_LIBRARY_NAME) {
+ if (doc.printedName(type.library) == HTML_LIBRARY_NAME) {
// If it's an HTML type, try to map it to a base DOM type so we can find
// the MDN docs.
final domTypes = _diff.htmlTypesToDom[type.qualifiedName];
@@ -494,7 +494,7 @@ class Apidoc extends doc.Dartdoc {
MdnComment includeMdnMemberComment(MemberMirror member) {
var library = findLibrary(member);
var memberString = '';
- if (library.simpleName == HTML_LIBRARY_NAME) {
+ if (doc.printedName(library)== HTML_LIBRARY_NAME) {
// If it's an HTML type, try to map it to a DOM type name so we can find
// the MDN docs.
final domMembers = _diff.htmlToDom[member.qualifiedName];
@@ -575,4 +575,4 @@ class MdnComment implements doc.DocComment {
}
String toString() => mdnComment;
-}
+}

Powered by Google App Engine
This is Rietveld 408576698