Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1126283004: NEW public API for pdfwindow font manipulation (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

NEW public API for pdfwindow font manipulation. PDFium side of fix to make chromium free of private header includes. This moves the one snippet of contaminating code from chrome to PDFium itself. BUG=486818 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8f6445b83139349fa31a137496d54b1847a66d7c

Patch Set 1 #

Patch Set 2 : Rework to use thestig's suggestion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M public/fpdf_sysfontinfo.h View 1 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Tom Sepez
Lei, for review.
5 years, 7 months ago (2015-05-11 23:40:13 UTC) #2
Lei Zhang
Should we expose CPWL_FontMap::CharsetFontMap as FPDF_CharsetFontMap, and provide a function to get |CPWL_FontMap::defaultTTFMap| ? It's ...
5 years, 7 months ago (2015-05-12 00:46:24 UTC) #3
Tom Sepez
On 2015/05/12 00:46:24, Lei Zhang wrote: > Should we expose CPWL_FontMap::CharsetFontMap as FPDF_CharsetFontMap, and > ...
5 years, 7 months ago (2015-05-12 15:51:21 UTC) #4
Tom Sepez
Updated.
5 years, 7 months ago (2015-05-12 17:08:19 UTC) #5
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-12 18:14:46 UTC) #6
Tom Sepez
5 years, 7 months ago (2015-05-12 19:24:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8f6445b83139349fa31a137496d54b1847a66d7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698