Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1126273005: Fixed url parameters for AIDE requests. (Closed)

Created:
5 years, 7 months ago by Polina Bondarenko
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed url parameters for AIDE requests. Changed url parameters for DeviceAttributeUpdate[Permission]Request attribute_update[_permission] to device_attribute_update[permission] BUG=488117 Committed: https://crrev.com/f013b3c8336b7bf6dee5a84eef1832fc578aedcf Cr-Commit-Position: refs/heads/master@{#330072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/policy/core/common/cloud/cloud_policy_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Polina Bondarenko
Hi Andrew, please take a look. There were some mismatch on server and client side ...
5 years, 7 months ago (2015-05-14 17:02:27 UTC) #2
Andrew T Wilson (Slow)
lgtm probably should reach out to test team to let them know about this change ...
5 years, 7 months ago (2015-05-15 09:53:39 UTC) #3
Polina Bondarenko
On 2015/05/15 09:53:39, Andrew T Wilson wrote: > lgtm > > probably should reach out ...
5 years, 7 months ago (2015-05-15 09:56:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126273005/1
5 years, 7 months ago (2015-05-15 09:56:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 10:40:08 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 10:40:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f013b3c8336b7bf6dee5a84eef1832fc578aedcf
Cr-Commit-Position: refs/heads/master@{#330072}

Powered by Google App Engine
This is Rietveld 408576698