Source/core/dom/SandboxFlags.cpp - Issue 1126253007: Block modal dialogs inside sandboxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/SandboxFlags.cpp

Issue 1126253007: Block modal dialogs inside sandboxes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: WebSandboxFlags. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/SandboxFlags.cpp

diff --git a/Source/core/dom/SandboxFlags.cpp b/Source/core/dom/SandboxFlags.cpp

index 157685d4a21b773a51ef79f5287697282ff30cec..d3ca254f87705812c242470a946fef08adfbfdfe 100644

--- a/Source/core/dom/SandboxFlags.cpp

+++ b/Source/core/dom/SandboxFlags.cpp

@@ -68,6 +68,8 @@ SandboxFlags parseSandboxPolicy(const SpaceSplitString& policy, String& invalidT

flags &= ~SandboxOrientationLock;

} else if (equalIgnoringCase(sandboxToken, "allow-unsandboxed-auxiliary") && RuntimeEnabledFeatures::unsandboxedAuxiliaryEnabled()) {

flags &= ~SandboxPropagatesToAuxiliaryBrowsingContexts;

+ } else if (equalIgnoringCase(sandboxToken, "allow-modals") && RuntimeEnabledFeatures::sandboxBlocksModalsEnabled()) {

+ flags &= ~SandboxModals;

} else {

if (numberOfTokenErrors)

tokenErrors.appendLiteral(", '");