LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html - Issue 1126253007: Block modal dialogs inside sandboxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

Issue 1126253007: Block modal dialogs inside sandboxes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: WebSandboxFlags. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt ('k') | LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt » ('j') | Source/core/frame/LocalDOMWindow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

diff --git a/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html b/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

index fe173d6cca6acbff24509d79adac7f888d7fb687..406e2b6d9860689a6699dd0dda630bf43ba59831 100644

--- a/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

+++ b/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html

@@ -11,6 +11,6 @@ if (window.testRunner) {

src="data:text/html,

- var win = window.open('data:text/html,<form action=javascript:alert(/PASS/) ><input type=submit></form><script>document.forms[0].submit(); if (window.testRunner) testRunner.notifyDone();<\/script>', '_blank');

+ var win = window.open('data:text/html,<form action=javascript:console.log(/PASS/) ><input type=submit></form><script>document.forms[0].submit(); if (window.testRunner) testRunner.notifyDone();<\/script>', '_blank');

</script>"

></iframe>