Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: cc/test/layer_tree_test.cc

Issue 1126253005: cc: Add LayerTreeHost::InitParams for LayerTreeHost creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/fake_layer_tree_host.cc ('k') | cc/trees/layer_tree_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/layer_tree_test.cc
diff --git a/cc/test/layer_tree_test.cc b/cc/test/layer_tree_test.cc
index 055d0817d30466ff13be525e2b5edc9dedb5bd5a..b11f41ab4172309ee0757daf5b752760da2c9ee2 100644
--- a/cc/test/layer_tree_test.cc
+++ b/cc/test/layer_tree_test.cc
@@ -460,10 +460,14 @@ class LayerTreeHostForTesting : public LayerTreeHost {
scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> impl_task_runner,
scoped_ptr<BeginFrameSource> external_begin_frame_source) {
+ LayerTreeHost::InitParams params;
+ params.client = client;
+ params.shared_bitmap_manager = shared_bitmap_manager;
+ params.gpu_memory_buffer_manager = gpu_memory_buffer_manager;
+ params.task_graph_runner = task_graph_runner;
+ params.settings = &settings;
scoped_ptr<LayerTreeHostForTesting> layer_tree_host(
- new LayerTreeHostForTesting(test_hooks, client, shared_bitmap_manager,
- gpu_memory_buffer_manager,
- task_graph_runner, settings));
+ new LayerTreeHostForTesting(test_hooks, &params));
if (impl_task_runner.get()) {
layer_tree_host->InitializeForTesting(
ThreadProxyForTest::Create(test_hooks,
@@ -487,8 +491,8 @@ class LayerTreeHostForTesting : public LayerTreeHost {
LayerTreeHostImplClient* host_impl_client) override {
return LayerTreeHostImplForTesting::Create(
test_hooks_, settings(), host_impl_client, proxy(),
- shared_bitmap_manager_, gpu_memory_buffer_manager_, task_graph_runner_,
- rendering_stats_instrumentation());
+ shared_bitmap_manager(), gpu_memory_buffer_manager(),
+ task_graph_runner(), rendering_stats_instrumentation());
}
void SetNeedsCommit() override {
@@ -500,23 +504,10 @@ class LayerTreeHostForTesting : public LayerTreeHost {
void set_test_started(bool started) { test_started_ = started; }
private:
- LayerTreeHostForTesting(
- TestHooks* test_hooks,
- LayerTreeHostClient* client,
- SharedBitmapManager* shared_bitmap_manager,
- gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
- TaskGraphRunner* task_graph_runner,
- const LayerTreeSettings& settings)
- : LayerTreeHost(client, NULL, NULL, NULL, settings),
- shared_bitmap_manager_(shared_bitmap_manager),
- gpu_memory_buffer_manager_(gpu_memory_buffer_manager),
- task_graph_runner_(task_graph_runner),
- test_hooks_(test_hooks),
- test_started_(false) {}
+ LayerTreeHostForTesting(TestHooks* test_hooks,
+ LayerTreeHost::InitParams* params)
+ : LayerTreeHost(params), test_hooks_(test_hooks), test_started_(false) {}
- SharedBitmapManager* shared_bitmap_manager_;
- gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager_;
- TaskGraphRunner* task_graph_runner_;
TestHooks* test_hooks_;
bool test_started_;
};
« no previous file with comments | « cc/test/fake_layer_tree_host.cc ('k') | cc/trees/layer_tree_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698