cc: Add LayerTreeHost::InitParams for LayerTreeHost creation.

cc/test/fake_layer_tree_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/fake_layer_tree_host.h"
 
 namespace cc {
 FakeLayerTreeHost::FakeLayerTreeHost(FakeLayerTreeHostClient* client,
-                                     const LayerTreeSettings& settings)
-    : LayerTreeHost(client, NULL, NULL, NULL, settings),
+                                     LayerTreeHost::InitParams* params)
+    : LayerTreeHost(params),
       client_(client),
-      host_impl_(settings, &proxy_, &manager_, nullptr),
+      host_impl_(params->settings ? *params->settings : LayerTreeSettings(),

[danakj, 2015/05/07 00:59:56]

not a fan, this is a bit unobvious. i'd rather the settings always given to the
InitParams.

it /could/ even be a const& if you passed it to the constructor. if you want, no
strong feelings here.

[sadrul, 2015/05/07 04:39:25]

Removed the NULL check (and kept settings as a ptr).

+                 &proxy_,
+                 &manager_,
+                 nullptr),
       needs_commit_(false) {
   client_->SetLayerTreeHost(this);
 }
 
 scoped_ptr<FakeLayerTreeHost> FakeLayerTreeHost::Create(
     FakeLayerTreeHostClient* client) {
   LayerTreeSettings settings;
   settings.verify_property_trees = true;
-  return make_scoped_ptr(new FakeLayerTreeHost(client, settings));
+  return Create(client, settings);
 }
 
 scoped_ptr<FakeLayerTreeHost> FakeLayerTreeHost::Create(
     FakeLayerTreeHostClient* client,
     const LayerTreeSettings& settings) {
-  return make_scoped_ptr(new FakeLayerTreeHost(client, settings));
+  LayerTreeHost::InitParams params;
+  params.client = client;
+  params.settings = &settings;
+  return make_scoped_ptr(new FakeLayerTreeHost(client, &params));
 }
 
 FakeLayerTreeHost::~FakeLayerTreeHost() {
   client_->SetLayerTreeHost(NULL);
 }
 
 void FakeLayerTreeHost::SetNeedsCommit() { needs_commit_ = true; }
 
 LayerImpl* FakeLayerTreeHost::CommitAndCreateLayerImplTree() {
   scoped_ptr<LayerImpl> old_root_layer_impl = active_tree()->DetachLayerTree();
 
   scoped_ptr<LayerImpl> layer_impl = TreeSynchronizer::SynchronizeTrees(
       root_layer(), old_root_layer_impl.Pass(), active_tree());
   TreeSynchronizer::PushProperties(root_layer(), layer_impl.get());
 
   active_tree()->SetRootLayer(layer_impl.Pass());
   return active_tree()->root_layer();
 }
 
 }  // namespace cc