gpu/command_buffer/service/program_manager.h - Issue 1126243002: Check for shader version mismatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/program_manager.h

Issue 1126243002: Check for shader version mismatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/program_manager.h

diff --git a/gpu/command_buffer/service/program_manager.h b/gpu/command_buffer/service/program_manager.h

index a3de24bfc5a42be6509e67eedd96d5bb59028a9c..a620ee2ae1593a52bf791f51daed2292b034f92c 100644

--- a/gpu/command_buffer/service/program_manager.h

+++ b/gpu/command_buffer/service/program_manager.h

@@ -213,6 +213,9 @@ class GPU_EXPORT Program : public base::RefCounted<Program> {

// returns false if error.

bool SetUniformLocationBinding(const std::string& name, GLint location);

+ // Detects if the shader version combination is not valid.

+ bool DetectShaderVersionMismatch() const;

// Detects if there are attribute location conflicts from

// glBindAttribLocation() calls.

// We only consider the declared attributes in the program.