Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 1126233011: Make blob scheme donwloadable through context menu (Closed)

Created:
5 years, 7 months ago by qinmin
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make blob scheme donwloadable through context menu Currently filesystem and data URIs are downloadable from context menu Blob urls should also be supported. Context menu downloads are handled by Chrome's network stack. So blob urls will be handled appropriately. BUG=481497 Committed: https://crrev.com/a06788a3f3318f65e4c56d8948bd8edd944fb599 Cr-Commit-Position: refs/heads/master@{#330777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/UrlUtilitiesTest.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
5 years, 7 months ago (2015-05-19 23:01:11 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 7 months ago (2015-05-20 17:29:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126233011/1
5 years, 7 months ago (2015-05-20 17:35:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 18:35:53 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 18:36:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a06788a3f3318f65e4c56d8948bd8edd944fb599
Cr-Commit-Position: refs/heads/master@{#330777}

Powered by Google App Engine
This is Rietveld 408576698