Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 1126213002: Wrap runtime.js in a function. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap runtime.js in a function. R=jkummerow@chromium.org Committed: https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 Cr-Commit-Position: refs/heads/master@{#28275}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -454 lines) Patch
M src/array.js View 21 chunks +26 lines, -26 lines 0 comments Download
M src/array-iterator.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/ast-value-factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M src/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/date.js View 20 chunks +57 lines, -57 lines 0 comments Download
M src/debug-debugger.js View 18 chunks +20 lines, -19 lines 0 comments Download
M src/harmony-array.js View 8 chunks +11 lines, -11 lines 0 comments Download
M src/harmony-array-includes.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.js View 1 8 chunks +8 lines, -8 lines 0 comments Download
M src/json.js View 3 chunks +7 lines, -7 lines 0 comments Download
M src/macros.py View 1 chunk +6 lines, -6 lines 0 comments Download
M src/math.js View 8 chunks +8 lines, -8 lines 0 comments Download
M src/messages.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mirror-debugger.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/object-observe.js View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.js View 48 chunks +243 lines, -145 lines 0 comments Download
M src/string.js View 10 chunks +15 lines, -15 lines 0 comments Download
M src/string-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/symbol.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/typedarray.js View 7 chunks +9 lines, -16 lines 0 comments Download
M src/uri.js View 4 chunks +6 lines, -6 lines 0 comments Download
M src/v8natives.js View 1 27 chunks +42 lines, -41 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/samevalue.js View 1 chunk +58 lines, -56 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years, 7 months ago (2015-05-06 13:19:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126213002/1
5 years, 7 months ago (2015-05-06 14:04:28 UTC) #3
Jakob Kummerow
LGTM with a comment. https://codereview.chromium.org/1126213002/diff/1/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/1126213002/diff/1/src/i18n.js#newcode1269 src/i18n.js:1269: var number = $toNumber(value + ...
5 years, 7 months ago (2015-05-06 14:20:30 UTC) #5
Yang
On 2015/05/06 14:20:30, Jakob wrote: > LGTM with a comment. > > https://codereview.chromium.org/1126213002/diff/1/src/i18n.js > File ...
5 years, 7 months ago (2015-05-06 18:58:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126213002/20001
5 years, 7 months ago (2015-05-06 18:58:50 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 19:24:58 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 Cr-Commit-Position: refs/heads/master@{#28275}
5 years, 7 months ago (2015-05-06 19:25:10 UTC) #11
Michael Achenbach
5 years, 7 months ago (2015-05-06 20:02:21 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1123353004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds....

Powered by Google App Engine
This is Rietveld 408576698