Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1126203011: Start displaying title text for HTML elements without links. (Closed)

Created:
5 years, 7 months ago by aurimas (slooooooooow)
Modified:
5 years, 7 months ago
Reviewers:
Ted C, palmer, no sievers
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start displaying title text for HTML elements without links. This CL depends on Blink change https://chromiumcodereview.appspot.com/1128933011 BUG=487782 Committed: https://crrev.com/f04695585e3c0e532aa7c6f3dda04832b6c6fdc5 Cr-Commit-Position: refs/heads/master@{#330282}

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : Ted's comments addressed #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java View 1 2 3 4 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/context_menu_helper.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/context_menu_params.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/context_menu_params_builder.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
aurimas (slooooooooow)
PTAL
5 years, 7 months ago (2015-05-15 23:14:45 UTC) #2
Ted C
lgtm https://chromiumcodereview.appspot.com/1126203011/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java (right): https://chromiumcodereview.appspot.com/1126203011/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java#newcode114 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java:114: * @return The title or alt atribute (if ...
5 years, 7 months ago (2015-05-15 23:24:55 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/1126203011/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java (right): https://chromiumcodereview.appspot.com/1126203011/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java#newcode114 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java:114: * @return The title or alt atribute (if title ...
5 years, 7 months ago (2015-05-15 23:34:11 UTC) #4
aurimas (slooooooooow)
+palmer for content/common/frame_messages.h +sievers for rest of content/
5 years, 7 months ago (2015-05-15 23:36:06 UTC) #6
palmer
lgtm
5 years, 7 months ago (2015-05-15 23:44:30 UTC) #7
no sievers
lgtm
5 years, 7 months ago (2015-05-15 23:53:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126203011/40001
5 years, 7 months ago (2015-05-16 04:52:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/54287)
5 years, 7 months ago (2015-05-16 04:55:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126203011/60001
5 years, 7 months ago (2015-05-16 05:16:32 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-16 06:13:36 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:40 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f04695585e3c0e532aa7c6f3dda04832b6c6fdc5
Cr-Commit-Position: refs/heads/master@{#330282}

Powered by Google App Engine
This is Rietveld 408576698