Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1126203008: Avoid a race between libusb_submit_transfer and libusb_free_transfer. (Closed)

Created:
5 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid a race between libusb_submit_transfer and libusb_free_transfer. The tail end of libusb_submit_transfer assumes that the transfer object is still valid. It may in fact have already been freed by the transfer completion callback if that call occurs on a different thread. As a simply workaround (since the libusb code will be going away soon) this patch simply posts the transfer deletion back to the thread where libusb_submit_transfer is called so that they are serialized. BUG=487712 Committed: https://crrev.com/ce48c8a39c88803c6ca73c1fb4cf07f73fec7939 Cr-Commit-Position: refs/heads/master@{#329953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M device/usb/usb_device_handle_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 7 months ago (2015-05-14 19:41:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126203008/1
5 years, 7 months ago (2015-05-14 21:06:27 UTC) #4
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-14 21:41:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126203008/1
5 years, 7 months ago (2015-05-14 21:44:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 22:27:21 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 22:28:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce48c8a39c88803c6ca73c1fb4cf07f73fec7939
Cr-Commit-Position: refs/heads/master@{#329953}

Powered by Google App Engine
This is Rietveld 408576698