Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: tools/bots/compiler.py

Issue 11262028: Testing support for running tests minified in dart2js. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 14062)
+++ tools/bots/compiler.py (working copy)
@@ -20,7 +20,7 @@
import bot
DART2JS_BUILDER = (
- r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?-?(\d*)-?(\d*)')
+ r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?(-(minify))?-?(\d*)-?(\d*)')
WEB_BUILDER = (
r'dart2js-(ie9|ie10|ff|safari|chrome|opera)-(win7|win8|mac|linux)(-(all|html))?')
@@ -35,6 +35,7 @@
system = None
checked = False
host_checked = False
+ minify = False
shard_index = None
total_shards = None
test_set = None
@@ -66,8 +67,10 @@
host_checked = True
if dart2js_pattern.group(8) == 'host-checked':
host_checked = True
- shard_index = dart2js_pattern.group(9)
- total_shards = dart2js_pattern.group(10)
+ if dart2js_pattern.group(10) == 'minify':
+ minify = True
+ shard_index = dart2js_pattern.group(11)
+ total_shards = dart2js_pattern.group(12)
else :
return None
@@ -82,7 +85,8 @@
return None
return bot.BuildInfo(compiler, runtime, mode, system, checked, host_checked,
- shard_index, total_shards, is_buildbot, test_set)
+ minify, shard_index, total_shards, is_buildbot,
+ test_set)
def NeedsXterm(compiler, runtime):
@@ -275,6 +279,8 @@
if build_info.host_checked: test_flags += ['--host-checked']
+ if build_info.minify: test_flags += ['--minify']
+
TestCompiler(build_info.runtime, build_info.mode, build_info.system,
list(test_flags), build_info.is_buildbot, build_info.test_set)

Powered by Google App Engine
This is Rietveld 408576698