Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1126193004: fix path op builder (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix path op builder The rewrite of path ops caused the inner contour direction to be reversed. This exposed an existing bug in path ops builder, namely that the implicit winding of the internal sum path could hide inner contours if they ended up in the wrong direction. Setting the sum path's fill type to even-odd ensures that the inner contours aren't discarded. R=fmalita@chromium.org BUG=skia:3838 Committed: https://skia.googlesource.com/skia/+/fba9da78acf8853f0074d0518411bafc827f3771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126193004/1
5 years, 7 months ago (2015-05-14 18:38:41 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-14 18:38:42 UTC) #3
f(malita)
lgtm
5 years, 7 months ago (2015-05-14 19:14:22 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 21:18:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fba9da78acf8853f0074d0518411bafc827f3771

Powered by Google App Engine
This is Rietveld 408576698