chrome/installer/mini_installer/mini_string.cc - Issue 1126163003: mini_installer: Change to use _countof rather than base's arraysize macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer/mini_string.cc

Issue 1126163003: mini_installer: Change to use _countof rather than base's arraysize macro. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/mini_installer/mini_installer.cc ('K') | « chrome/installer/mini_installer/mini_installer.cc ('k') | chrome/installer/mini_installer/mini_string_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/mini_installer/mini_string.cc

diff --git a/chrome/installer/mini_installer/mini_string.cc b/chrome/installer/mini_installer/mini_string.cc

index c5e401a1621f8d03eeeea276e286f1b744c2782e..1f4b3f10294cdcd064782fdaeb70830f481f0e99 100644

--- a/chrome/installer/mini_installer/mini_string.cc

+++ b/chrome/installer/mini_installer/mini_string.cc

@@ -68,8 +68,8 @@ bool SafeStrCopy(wchar_t* dest, size_t dest_size, const wchar_t* src) {

// failed concatenation. For example:

// wchar_t buf[5] = {0};

- // if (!SafeStrCat(buf, arraysize(buf), kLongName))

- // SafeStrCat(buf, arraysize(buf), kShortName);

+ // if (!SafeStrCat(buf, _countof(buf), kLongName))

+ // SafeStrCat(buf, _countof(buf), kShortName);

// If we were to return false in the first call to SafeStrCat but still

// mutate the buffer, the buffer will be in an unexpected state.