Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3904)

Unified Diff: chrome/installer/mini_installer/configuration_test.cc

Issue 1126163003: mini_installer: Change to use _countof rather than base's arraysize macro. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer/configuration_test.cc
diff --git a/chrome/installer/mini_installer/configuration_test.cc b/chrome/installer/mini_installer/configuration_test.cc
index 22333a1597191e37317ef4449b3d48a13541d1e1..14e21c0769f87de1d33ed15214da9bb1df31765e 100644
--- a/chrome/installer/mini_installer/configuration_test.cc
+++ b/chrome/installer/mini_installer/configuration_test.cc
@@ -2,9 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/installer/mini_installer/configuration.h"
+
+#include <stdlib.h>
+
#include "base/basictypes.h"
#include "chrome/installer/mini_installer/appid.h"
-#include "chrome/installer/mini_installer/configuration.h"
#include "testing/gtest/include/gtest/gtest.h"
using mini_installer::Configuration;
@@ -57,7 +60,7 @@ TEST(MiniInstallerConfigurationTest, CommandLine) {
L"spam.exe",
L"spam.exe --foo",
};
- for (size_t i = 0; i < arraysize(kCommandLines); ++i) {
+ for (size_t i = 0; i < _countof(kCommandLines); ++i) {
grt (UTC plus 2) 2015/05/06 16:46:34 use new C++ here: for (const wchar_t* command_li
tfarina 2015/05/06 17:21:55 Done.
EXPECT_TRUE(std::wstring(kCommandLines[i]) ==
TestConfiguration(kCommandLines[i]).command_line());
}
« no previous file with comments | « no previous file | chrome/installer/mini_installer/decompress.h » ('j') | chrome/installer/mini_installer/decompress.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698