Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1126143004: [Android] Add option to wait for battery temperature to device provisioning (Closed)

Created:
5 years, 7 months ago by rnephew (Reviews Here)
Modified:
5 years, 7 months ago
Reviewers:
perezju, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add option to wait for battery temperature to device provisioning If too many tests are run one after another, battery temperatures can become abnormally high. This gives the device a chance to cool down between runs. BUG= Committed: https://crrev.com/7ce719b80a3358f0f930b004fde3c452d1a1c9ec Cr-Commit-Position: refs/heads/master@{#328716}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M build/android/provision_devices.py View 2 chunks +8 lines, -0 lines 0 comments Download
M build/android/pylib/device/battery_utils.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 1 2 4 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
rnephew (Reviews Here)
5 years, 7 months ago (2015-05-06 18:27:58 UTC) #2
jbudorick
test? https://codereview.chromium.org/1126143004/diff/1/build/android/pylib/device/battery_utils.py File build/android/pylib/device/battery_utils.py (right): https://codereview.chromium.org/1126143004/diff/1/build/android/pylib/device/battery_utils.py#newcode402 build/android/pylib/device/battery_utils.py:402: nit: log at info level that we're waiting ...
5 years, 7 months ago (2015-05-07 00:07:14 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/1126143004/diff/1/build/android/pylib/device/battery_utils.py File build/android/pylib/device/battery_utils.py (right): https://codereview.chromium.org/1126143004/diff/1/build/android/pylib/device/battery_utils.py#newcode402 build/android/pylib/device/battery_utils.py:402: On 2015/05/07 00:07:14, jbudorick wrote: > nit: log at ...
5 years, 7 months ago (2015-05-07 01:40:03 UTC) #4
jbudorick
lgtm w/ nit https://codereview.chromium.org/1126143004/diff/20001/build/android/pylib/device/battery_utils_test.py File build/android/pylib/device/battery_utils_test.py (right): https://codereview.chromium.org/1126143004/diff/20001/build/android/pylib/device/battery_utils_test.py#newcode311 build/android/pylib/device/battery_utils_test.py:311: class BatteryUtilsLetBatteryCoolToTemperature(BatteryUtilsTest): ...Test
5 years, 7 months ago (2015-05-07 03:30:06 UTC) #5
rnephew (Reviews Here)
https://codereview.chromium.org/1126143004/diff/20001/build/android/pylib/device/battery_utils_test.py File build/android/pylib/device/battery_utils_test.py (right): https://codereview.chromium.org/1126143004/diff/20001/build/android/pylib/device/battery_utils_test.py#newcode311 build/android/pylib/device/battery_utils_test.py:311: class BatteryUtilsLetBatteryCoolToTemperature(BatteryUtilsTest): On 2015/05/07 03:30:06, jbudorick wrote: > ...Test ...
5 years, 7 months ago (2015-05-07 04:07:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126143004/40001
5 years, 7 months ago (2015-05-07 04:08:39 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-07 05:36:01 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7ce719b80a3358f0f930b004fde3c452d1a1c9ec Cr-Commit-Position: refs/heads/master@{#328716}
5 years, 7 months ago (2015-05-07 05:37:42 UTC) #11
perezju
5 years, 7 months ago (2015-05-07 08:58:00 UTC) #12
Message was sent while issue was closed.
already landed, but just wanted to comment that this is very neat :) lgtm too

Powered by Google App Engine
This is Rietveld 408576698