Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1126123004: Use TestDiscardableMemoryAllocator in filter_fuzz_stub. (Closed)

Created:
5 years, 7 months ago by Martin Barbella
Modified:
5 years, 7 months ago
Reviewers:
sugoi1, sugoi, inferno
CC:
chromium-reviews, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TestDiscardableMemoryAllocator in filter_fuzz_stub. R=sugoi@chromium.org,sugoi@google.com BUG= Committed: https://crrev.com/593baab3ff8a986e3a2e88f2b9d190ed0d03f4fa Cr-Commit-Position: refs/heads/master@{#329013}

Patch Set 1 #

Patch Set 2 : Also update BUILD.gn #

Patch Set 3 : Update BUILD.gn for filter_fuzz_stub #

Patch Set 4 : Mark filter fuzz stub as testonly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M skia/BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
Martin Barbella
PTAL. From a quick look, it seems like it's probably reasonable to apply the patch. ...
5 years, 7 months ago (2015-05-08 16:37:57 UTC) #2
sugoi1
On 2015/05/08 16:37:57, mbarbella wrote: > PTAL. > > From a quick look, it seems ...
5 years, 7 months ago (2015-05-08 17:02:43 UTC) #3
sugoi1
On 2015/05/08 16:37:57, mbarbella wrote: > PTAL. > > From a quick look, it seems ...
5 years, 7 months ago (2015-05-08 17:02:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/1
5 years, 7 months ago (2015-05-08 17:05:19 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-08 17:05:22 UTC) #8
sugoi
On 2015/05/08 17:05:22, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 7 months ago (2015-05-08 17:18:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/1
5 years, 7 months ago (2015-05-08 17:22:05 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-08 17:22:09 UTC) #13
inferno
lgtm
5 years, 7 months ago (2015-05-08 17:22:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/1
5 years, 7 months ago (2015-05-08 17:24:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/86776)
5 years, 7 months ago (2015-05-08 17:34:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/60001
5 years, 7 months ago (2015-05-08 18:39:13 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-08 19:34:49 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 19:35:36 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/593baab3ff8a986e3a2e88f2b9d190ed0d03f4fa
Cr-Commit-Position: refs/heads/master@{#329013}

Powered by Google App Engine
This is Rietveld 408576698