|
|
Created:
5 years, 7 months ago by Martin Barbella Modified:
5 years, 7 months ago CC:
chromium-reviews, inferno Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TestDiscardableMemoryAllocator in filter_fuzz_stub.
R=sugoi@chromium.org,sugoi@google.com
BUG=
Committed: https://crrev.com/593baab3ff8a986e3a2e88f2b9d190ed0d03f4fa
Cr-Commit-Position: refs/heads/master@{#329013}
Patch Set 1 #Patch Set 2 : Also update BUILD.gn #Patch Set 3 : Update BUILD.gn for filter_fuzz_stub #Patch Set 4 : Mark filter fuzz stub as testonly #
Messages
Total messages: 24 (10 generated)
mbarbella@chromium.org changed reviewers: + sugoi@google.com - sugoi@chromium.org
PTAL. From a quick look, it seems like it's probably reasonable to apply the patch. Before it was applied, some of the test cases are crashing at: Program received signal SIGSEGV, Segmentation fault. 0x0000000000acbc9b in Create () at ../../skia/ext/SkDiscardableMemory_chrome.cc:31 31 base::DiscardableMemoryAllocator::GetInstance() (gdb) bt #0 0x0000000000acbc9b in Create () at ../../skia/ext/SkDiscardableMemory_chrome.cc:31 #1 0x00000000007e76ca in allocPixelRef () at ../../third_party/skia/src/core/SkResourceCache.cpp:166 #2 0x00000000007e55a7 in cache_try_alloc_pixels () at ../../third_party/skia/src/core/SkPictureShader.cpp:98 #3 refBitmapShader () at ../../third_party/skia/src/core/SkPictureShader.cpp:207 #4 0x00000000007e6311 in onCreateContext () at ../../third_party/skia/src/core/SkPictureShader.cpp:234 #5 0x00000000006266e0 in createContext () at ../../third_party/skia/src/core/SkShader.cpp:92 #6 0x00000000007a1f13 in Choose () at ../../third_party/skia/src/core/SkBlitter.cpp:927
On 2015/05/08 16:37:57, mbarbella wrote: > PTAL. > > From a quick look, it seems like it's probably reasonable to apply the patch. > Before it was applied, some of the test cases are crashing at: > > Program received signal SIGSEGV, Segmentation fault. > 0x0000000000acbc9b in Create () > at ../../skia/ext/SkDiscardableMemory_chrome.cc:31 > 31 base::DiscardableMemoryAllocator::GetInstance() > (gdb) bt > #0 0x0000000000acbc9b in Create () > at ../../skia/ext/SkDiscardableMemory_chrome.cc:31 > #1 0x00000000007e76ca in allocPixelRef () > at ../../third_party/skia/src/core/SkResourceCache.cpp:166 > #2 0x00000000007e55a7 in cache_try_alloc_pixels () > at ../../third_party/skia/src/core/SkPictureShader.cpp:98 > #3 refBitmapShader () > at ../../third_party/skia/src/core/SkPictureShader.cpp:207 > #4 0x00000000007e6311 in onCreateContext () > at ../../third_party/skia/src/core/SkPictureShader.cpp:234 > #5 0x00000000006266e0 in createContext () > at ../../third_party/skia/src/core/SkShader.cpp:92 > #6 0x00000000007a1f13 in Choose () > at ../../third_party/skia/src/core/SkBlitter.cpp:927 lgtm
On 2015/05/08 16:37:57, mbarbella wrote: > PTAL. > > From a quick look, it seems like it's probably reasonable to apply the patch. > Before it was applied, some of the test cases are crashing at: > > Program received signal SIGSEGV, Segmentation fault. > 0x0000000000acbc9b in Create () > at ../../skia/ext/SkDiscardableMemory_chrome.cc:31 > 31 base::DiscardableMemoryAllocator::GetInstance() > (gdb) bt > #0 0x0000000000acbc9b in Create () > at ../../skia/ext/SkDiscardableMemory_chrome.cc:31 > #1 0x00000000007e76ca in allocPixelRef () > at ../../third_party/skia/src/core/SkResourceCache.cpp:166 > #2 0x00000000007e55a7 in cache_try_alloc_pixels () > at ../../third_party/skia/src/core/SkPictureShader.cpp:98 > #3 refBitmapShader () > at ../../third_party/skia/src/core/SkPictureShader.cpp:207 > #4 0x00000000007e6311 in onCreateContext () > at ../../third_party/skia/src/core/SkPictureShader.cpp:234 > #5 0x00000000006266e0 in createContext () > at ../../third_party/skia/src/core/SkShader.cpp:92 > #6 0x00000000007a1f13 in Choose () > at ../../third_party/skia/src/core/SkBlitter.cpp:927 lgtm
The CQ bit was checked by mbarbella@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/05/08 17:05:22, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by mbarbella@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
inferno@chromium.org changed reviewers: + inferno@chromium.org
lgtm
The CQ bit was checked by mbarbella@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mbarbella@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sugoi@chromium.org, sugoi@google.com, inferno@chromium.org Link to the patchset: https://codereview.chromium.org/1126123004/#ps60001 (title: "Mark filter fuzz stub as testonly")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126123004/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/593baab3ff8a986e3a2e88f2b9d190ed0d03f4fa Cr-Commit-Position: refs/heads/master@{#329013} |