Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1126113003: Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #6 id:100001 of https://codereview.chromium.org/1114383003/) Reason for revert: Even adding methods which are not called breaks this bot. How in the hell is this possible? http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579 http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/stdio Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} > > Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b > Cr-Commit-Position: refs/heads/master@{#328351} > > Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 > Cr-Commit-Position: refs/heads/master@{#328909} > > Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1 > Cr-Commit-Position: refs/heads/master@{#329003} TBR=rtenneti@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1700960f576b111c00bd29fb72d27beddffecc7a Cr-Commit-Position: refs/heads/master@{#329015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M jingle/glue/chrome_async_socket_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/socket/socket_test_util.h View 3 chunks +0 lines, -6 lines 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M remoting/base/buffered_socket_writer_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Hamilton
Created Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
5 years, 7 months ago (2015-05-08 19:33:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126113003/1
5 years, 7 months ago (2015-05-08 19:34:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 19:36:47 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 19:38:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1700960f576b111c00bd29fb72d27beddffecc7a
Cr-Commit-Position: refs/heads/master@{#329015}

Powered by Google App Engine
This is Rietveld 408576698