Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: src/runtime/runtime-debug.cc

Issue 1126103006: Provide accessor for object internal properties that doesn't require debugger to be active (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-debug.cc
diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc
index 239f2b2e38f36ab7b30a111ce223a5f362525cb7..821eb90cf84af13d9b0f02a244fd41268a5f5c74 100644
--- a/src/runtime/runtime-debug.cc
+++ b/src/runtime/runtime-debug.cc
@@ -101,6 +101,156 @@ static Handle<Object> DebugGetProperty(LookupIterator* it,
}
+static Handle<Object> DebugGetProperty(Handle<Object> object,
+ Handle<Name> name) {
+ LookupIterator it(object, name);
+ return DebugGetProperty(&it);
+}
+
+
+template <class IteratorType>
+static MaybeHandle<JSArray> GetIteratorInternalProperties(
+ Isolate* isolate, Handle<IteratorType> object) {
+ Factory* factory = isolate->factory();
+ Handle<IteratorType> iterator = Handle<IteratorType>::cast(object);
+ RUNTIME_ASSERT_HANDLIFIED(iterator->kind()->IsSmi(), JSArray);
+ const char* kind = NULL;
+ switch (Smi::cast(iterator->kind())->value()) {
+ case IteratorType::kKindKeys:
+ kind = "keys";
+ break;
+ case IteratorType::kKindValues:
+ kind = "values";
+ break;
+ case IteratorType::kKindEntries:
+ kind = "entries";
+ break;
+ default:
+ RUNTIME_ASSERT_HANDLIFIED(false, JSArray);
+ }
+
+ Handle<FixedArray> result = factory->NewFixedArray(2 * 3);
+ result->set(0, *factory->NewStringFromAsciiChecked("[[IteratorHasMore]]"));
+ result->set(1, isolate->heap()->ToBoolean(iterator->HasMore()));
+
+ result->set(2, *factory->NewStringFromAsciiChecked("[[IteratorIndex]]"));
+ result->set(3, iterator->index());
+
+ result->set(4, *factory->NewStringFromAsciiChecked("[[IteratorKind]]"));
+ result->set(5, *factory->NewStringFromAsciiChecked(kind));
+ return factory->NewJSArrayWithElements(result);
+}
+
+
+MaybeHandle<JSArray> Runtime::GetInternalProperties(Isolate* isolate,
+ Handle<Object> object) {
+ Factory* factory = isolate->factory();
+ if (object->IsJSFunction()) {
+ Handle<JSFunction> function = Handle<JSFunction>::cast(object);
+ if (function->shared()->bound()) {
+ RUNTIME_ASSERT_HANDLIFIED(function->function_bindings()->IsFixedArray(),
+ JSArray);
+
+ Handle<FixedArray> bindings(function->function_bindings());
+
+ Handle<FixedArray> result = factory->NewFixedArray(2 * 3);
+ result->set(0, *factory->NewStringFromAsciiChecked("[[TargetFunction]]"));
+ result->set(1, bindings->get(JSFunction::kBoundFunctionIndex));
+
+ result->set(2, *factory->NewStringFromAsciiChecked("[[BoundThis]]"));
+ result->set(3, bindings->get(JSFunction::kBoundThisIndex));
+
+ Handle<FixedArray> arguments = factory->NewFixedArray(
+ bindings->length() - JSFunction::kBoundArgumentsStartIndex);
+ bindings->CopyTo(
+ JSFunction::kBoundArgumentsStartIndex, *arguments, 0,
+ bindings->length() - JSFunction::kBoundArgumentsStartIndex);
+ result->set(4, *factory->NewStringFromAsciiChecked("[[BoundArgs]]"));
+ result->set(5, *factory->NewJSArrayWithElements(arguments));
+ return factory->NewJSArrayWithElements(result);
+ }
+ } else if (object->IsJSMapIterator()) {
+ Handle<JSMapIterator> iterator = Handle<JSMapIterator>::cast(object);
+ return GetIteratorInternalProperties(isolate, iterator);
+ } else if (object->IsJSSetIterator()) {
+ Handle<JSSetIterator> iterator = Handle<JSSetIterator>::cast(object);
+ return GetIteratorInternalProperties(isolate, iterator);
+ } else if (object->IsJSGeneratorObject()) {
+ Handle<JSGeneratorObject> generator =
+ Handle<JSGeneratorObject>::cast(object);
+
+ const char* status = "suspended";
+ if (generator->is_closed()) {
+ status = "closed";
+ } else if (generator->is_executing()) {
+ status = "running";
+ } else {
+ DCHECK(generator->is_suspended());
+ }
+
+ Handle<FixedArray> result = factory->NewFixedArray(2 * 3);
+ result->set(0, *factory->NewStringFromAsciiChecked("[[GeneratorStatus]]"));
+ result->set(1, *factory->NewStringFromAsciiChecked(status));
+
+ result->set(2,
+ *factory->NewStringFromAsciiChecked("[[GeneratorFunction]]"));
+ result->set(3, generator->function());
+
+ result->set(4,
+ *factory->NewStringFromAsciiChecked("[[GeneratorReceiver]]"));
+ result->set(5, generator->receiver());
+ return factory->NewJSArrayWithElements(result);
+ } else if (Object::IsPromise(object)) {
+ Handle<JSObject> promise = Handle<JSObject>::cast(object);
+
+ Handle<Object> status_obj =
+ DebugGetProperty(promise, isolate->promise_status());
+ RUNTIME_ASSERT_HANDLIFIED(status_obj->IsSmi(), JSArray);
+ const char* status = "rejected";
+ int status_val = Handle<Smi>::cast(status_obj)->value();
+ switch (status_val) {
+ case +1:
+ status = "resolved";
+ break;
+ case 0:
+ status = "pending";
+ break;
+ default:
+ DCHECK_EQ(-1, status_val);
+ }
+
+ Handle<FixedArray> result = factory->NewFixedArray(2 * 2);
+ result->set(0, *factory->NewStringFromAsciiChecked("[[PromiseStatus]]"));
+ result->set(1, *factory->NewStringFromAsciiChecked(status));
+
+ Handle<Object> value_obj =
+ DebugGetProperty(promise, isolate->promise_value());
+ result->set(2, *factory->NewStringFromAsciiChecked("[[PromiseValue]]"));
+ result->set(3, *value_obj);
+ return factory->NewJSArrayWithElements(result);
+ } else if (object->IsJSValue()) {
+ Handle<JSValue> js_value = Handle<JSValue>::cast(object);
+
+ Handle<FixedArray> result = factory->NewFixedArray(2);
+ result->set(0, *factory->NewStringFromAsciiChecked("[[PrimitiveValue]]"));
+ result->set(1, js_value->value());
+ return factory->NewJSArrayWithElements(result);
+ }
+ return factory->NewJSArray(0);
+}
+
+
+RUNTIME_FUNCTION(Runtime_DebugGetInternalProperties) {
+ HandleScope scope(isolate);
+ DCHECK(args.length() == 1);
+ CONVERT_ARG_HANDLE_CHECKED(Object, obj, 0);
+ Handle<JSArray> result;
+ ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+ isolate, result, Runtime::GetInternalProperties(isolate, obj));
+ return *result;
+}
+
+
// Get debugger related details for an object property, in the following format:
// 0: Property value
// 1: Property details
« no previous file with comments | « src/runtime/runtime.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698