Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1126043004: Migrate error messages, part 10. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 10. R=mvstanton@chromium.org Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f Cr-Commit-Position: refs/heads/master@{#28357} Committed: https://crrev.com/0bbe7874483f46a275aa3201aafa33a0655d76b0 Cr-Commit-Position: refs/heads/master@{#28366}

Patch Set 1 #

Patch Set 2 : removed dead code #

Patch Set 3 : fixed and rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -228 lines) Patch
M src/api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/api-natives.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/builtins.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/debug.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/elements.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/factory.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/factory.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M src/isolate.cc View 1 2 5 chunks +8 lines, -9 lines 0 comments Download
M src/json.js View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M src/json-stringifier.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/messages.h View 1 2 6 chunks +37 lines, -0 lines 0 comments Download
M src/messages.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/messages.js View 1 2 4 chunks +0 lines, -21 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 17 chunks +53 lines, -72 lines 0 comments Download
M src/runtime.js View 1 2 13 chunks +13 lines, -13 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/runtime/runtime-date.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 3 chunks +5 lines, -9 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/messages.js View 5 chunks +61 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
Yang
5 years, 7 months ago (2015-05-11 14:14:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126043004/20001
5 years, 7 months ago (2015-05-11 14:14:39 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-11 14:40:08 UTC) #5
mvstanton
lgtm
5 years, 7 months ago (2015-05-12 08:06:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126043004/20001
5 years, 7 months ago (2015-05-12 08:14:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 08:17:02 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f Cr-Commit-Position: refs/heads/master@{#28357}
5 years, 7 months ago (2015-05-12 08:17:15 UTC) #10
Yang
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1130073005/ by yangguo@chromium.org. ...
5 years, 7 months ago (2015-05-12 08:32:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126043004/30001
5 years, 7 months ago (2015-05-12 13:14:40 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 7 months ago (2015-05-12 13:52:35 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:52:50 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0bbe7874483f46a275aa3201aafa33a0655d76b0
Cr-Commit-Position: refs/heads/master@{#28366}

Powered by Google App Engine
This is Rietveld 408576698