Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script Wrappable, const v8::Persistent<v8::Object>& wrapper) 615 void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script Wrappable, const v8::Persistent<v8::Object>& wrapper)
616 { 616 {
617 {{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>(); 617 {{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>();
618 {% if set_wrapper_reference_to_list %} 618 {% if set_wrapper_reference_to_list %}
619 v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper); 619 v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
620 V8WrapperInstantiationScope scope(creationContext, isolate); 620 V8WrapperInstantiationScope scope(creationContext, isolate);
621 {% for set_wrapper_reference_to in set_wrapper_reference_to_list %} 621 {% for set_wrapper_reference_to in set_wrapper_reference_to_list %}
622 {{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = im pl->{{set_wrapper_reference_to.name}}(); 622 {{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = im pl->{{set_wrapper_reference_to.name}}();
623 if ({{set_wrapper_reference_to.name}}) { 623 if ({{set_wrapper_reference_to.name}}) {
624 if (!DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, is olate)) 624 if (!DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, is olate))
625 {{set_wrapper_reference_to.name}}->wrap(creationContext, isolate); 625 {{set_wrapper_reference_to.name}}->wrap(isolate, creationContext);
626 DOMDataStore::setWrapperReference(wrapper, {{set_wrapper_reference_to.na me}}, isolate); 626 DOMDataStore::setWrapperReference(wrapper, {{set_wrapper_reference_to.na me}}, isolate);
627 } 627 }
628 {% endfor %} 628 {% endfor %}
629 {% endif %} 629 {% endif %}
630 {% if reachable_node_function %} 630 {% if reachable_node_function %}
631 // The {{reachable_node_function}}() method may return a reference or a poin ter. 631 // The {{reachable_node_function}}() method may return a reference or a poin ter.
632 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) { 632 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) {
633 Node* root = V8GCController::opaqueRootForGC(isolate, owner); 633 Node* root = V8GCController::opaqueRootForGC(isolate, owner);
634 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper); 634 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper);
635 return; 635 return;
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
1042 } 1042 }
1043 1043
1044 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 1044 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
1045 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 1045 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
1046 { 1046 {
1047 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 1047 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
1048 } 1048 }
1049 {% endfor %} 1049 {% endfor %}
1050 {% endif %} 1050 {% endif %}
1051 {% endblock %} 1051 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698