Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Side by Side Diff: tests/standalone/io/process_path_environment_test.dart

Issue 11260048: Look up executable on PATH when given environment variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove dead code and add tests. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/process_macos.cc ('k') | tests/standalone/io/process_path_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4 //
5 // Test that the executable is looked up on the user's PATH when spawning a
ahe 2012/10/31 06:46:46 I don't think this test matches its description. I
Bob Nystrom 2012/11/01 20:53:03 My unix knowledge is weak. What's the difference b
6 // process and environment variables are passed in.
7
8 #import('dart:io');
9
10 main() {
11 // Pick an app that we expect to be on the PATH that returns 0 when run with
12 // no arguments.
13 var executable = Platform.operatingSystem == 'windows' ? 'cmd.exe' : 'true';
14
15 var options = new ProcessOptions();
16 options.environment = new Map.from(Platform.environment);
17 options.environment['whatever'] = 'something';
ahe 2012/10/31 06:46:46 You're not testing that this environment variable
Bob Nystrom 2012/11/01 20:53:03 That's OK, I think. There are other tests that env
18
19 Process.run(executable, [], options).then((result) {
20 Expect.equals(0, result.exitCode);
21 });
22 }
OLDNEW
« no previous file with comments | « runtime/bin/process_macos.cc ('k') | tests/standalone/io/process_path_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698