Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1126003002: Replace v8::Handle with v8::Local in {ScriptFunctionCall.cpp, ToV8.h}. (Closed)

Created:
5 years, 7 months ago by hyunjunekim2
Modified:
5 years, 7 months ago
Reviewers:
haraken, yurys
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace v8::Handle with v8::Local in {ScriptFunctionCall.cpp, ToV8.h}. Replace v8::Handle with v8::Local in {ScriptFunctionCall.cpp, ToV8.h}. Because v8::Handle is an alias of v8::Local. BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/bindings/core/v8/ScriptFunctionCall.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ToV8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
hyunjunekim2
Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). Could you check this patch? Thank you.
5 years, 7 months ago (2015-05-06 23:05:57 UTC) #3
haraken
LGTM
5 years, 7 months ago (2015-05-06 23:13:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126003002/1
5 years, 7 months ago (2015-05-06 23:36:42 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 02:06:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195019

Powered by Google App Engine
This is Rietveld 408576698