Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1125903003: Add deprecation warning to requestMediaKeySystemAccess on insecure origins. (Closed)

Created:
5 years, 7 months ago by ddorwin
Modified:
5 years, 7 months ago
Reviewers:
jww, jrummell, philipj_slow
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add deprecation warning to requestMediaKeySystemAccess on insecure origins. For more details, see https://goo.gl/rStTGz and https://w3c.github.io/encrypted-media/#requestMediaKeySystemAccess. BUG=481604 TEST=Updated layout test; using requestMediaKeySystemAccess() on HTTP and HTTPS URLs. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195062

Patch Set 1 #

Patch Set 2 : rebase to fix patch failure on bots #

Total comments: 4

Patch Set 3 : feedback #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp View 1 2 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
ddorwin
https://codereview.chromium.org/1125573003/ jww: Please review everything. jrummell: Please review modules/encryptedmedia. philipj: Please OWNERS review core/
5 years, 7 months ago (2015-05-06 00:00:59 UTC) #2
ddorwin
That should have said this will land after https://codereview.chromium.org/1125573003/.
5 years, 7 months ago (2015-05-06 00:02:17 UTC) #3
philipj_slow
core/ LGTM and comments in modules/encryptedmedia/ https://codereview.chromium.org/1125903003/diff/20001/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp File Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp (right): https://codereview.chromium.org/1125903003/diff/20001/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp#newcode181 Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:181: if (document->isPrivilegedContext(errorMessage)) { ...
5 years, 7 months ago (2015-05-06 07:39:44 UTC) #4
ddorwin
https://codereview.chromium.org/1125903003/diff/20001/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp File Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp (right): https://codereview.chromium.org/1125903003/diff/20001/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp#newcode181 Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:181: if (document->isPrivilegedContext(errorMessage)) { On 2015/05/06 07:39:43, philipj_UTC2 wrote: > ...
5 years, 7 months ago (2015-05-06 20:41:36 UTC) #5
philipj_slow
Changes look good, LGTM for everything.
5 years, 7 months ago (2015-05-06 20:53:17 UTC) #6
jrummell
lgtm
5 years, 7 months ago (2015-05-06 20:58:43 UTC) #7
jww
David, lgtm, although you should try to run tools/metrics/histograms/update_use_counter_feature_enum.py to update histograms.xml. However, there's a ...
5 years, 7 months ago (2015-05-07 03:05:54 UTC) #8
ddorwin
On 2015/05/07 03:05:54, jww wrote: > David, lgtm, although you should try to run > ...
5 years, 7 months ago (2015-05-07 17:12:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125903003/60001
5 years, 7 months ago (2015-05-07 17:13:20 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 17:17:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195062

Powered by Google App Engine
This is Rietveld 408576698