Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1125893003: Delete unused FilterURLTermiate_* actions. (Closed)

Created:
5 years, 7 months ago by Alexei Svitkine (slow)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, asvitkine+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused FilterURLTermiate_* actions. These actions currently account for about 5% of Android UMA data (most taken by FilterURLTermiate_About) and also: a) do not have any owners, b) have typo in the name and c) are not even actual user actions (i.e. not directly user initiated). If this data is interesting to someone, the metrics can be re-added with a histogram, which doesn't carry timing info and thus would be much more efficient. BUG=387734 Committed: https://crrev.com/f65686cdf2a36ae94d4a39dbf5ec8d50ff7c8e4f Cr-Commit-Position: refs/heads/master@{#328393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Alexei Svitkine (slow)
avi: content/ mpearson: tools/metrics/
5 years, 7 months ago (2015-05-05 17:09:00 UTC) #2
Mark P
metrics lgtm
5 years, 7 months ago (2015-05-05 17:13:19 UTC) #3
Avi (use Gerrit)
These were added by Nasko in https://chromiumcodereview.appspot.com/12208056 two years ago. Nasko?
5 years, 7 months ago (2015-05-05 17:18:37 UTC) #5
nasko
On 2015/05/05 17:18:37, Avi wrote: > These were added by Nasko in https://chromiumcodereview.appspot.com/12208056 two > ...
5 years, 7 months ago (2015-05-05 17:27:23 UTC) #6
Alexei Svitkine (slow)
On 2015/05/05 17:27:23, nasko wrote: > On 2015/05/05 17:18:37, Avi wrote: > > These were ...
5 years, 7 months ago (2015-05-05 17:32:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125893003/1
5 years, 7 months ago (2015-05-05 17:36:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 20:29:28 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 20:30:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f65686cdf2a36ae94d4a39dbf5ec8d50ff7c8e4f
Cr-Commit-Position: refs/heads/master@{#328393}

Powered by Google App Engine
This is Rietveld 408576698