Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/arm64/code-stubs-arm64.cc

Issue 1125783002: [es6] When comparing two symbols we may need to throw a TypeError (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 __ Cmp(right, left); 217 __ Cmp(right, left);
218 __ B(ne, &not_identical); 218 __ B(ne, &not_identical);
219 219
220 // Test for NaN. Sadly, we can't just compare to factory::nan_value(), 220 // Test for NaN. Sadly, we can't just compare to factory::nan_value(),
221 // so we do the second best thing - test it ourselves. 221 // so we do the second best thing - test it ourselves.
222 // They are both equal and they are not both Smis so both of them are not 222 // They are both equal and they are not both Smis so both of them are not
223 // Smis. If it's not a heap number, then return equal. 223 // Smis. If it's not a heap number, then return equal.
224 if ((cond == lt) || (cond == gt)) { 224 if ((cond == lt) || (cond == gt)) {
225 __ JumpIfObjectType(right, scratch, scratch, FIRST_SPEC_OBJECT_TYPE, slow, 225 __ JumpIfObjectType(right, scratch, scratch, FIRST_SPEC_OBJECT_TYPE, slow,
226 ge); 226 ge);
227 __ JumpIfObjectType(right, scratch, scratch, SYMBOL_TYPE, slow, eq);
227 } else if (cond == eq) { 228 } else if (cond == eq) {
228 __ JumpIfHeapNumber(right, &heap_number); 229 __ JumpIfHeapNumber(right, &heap_number);
229 } else { 230 } else {
230 Register right_type = scratch; 231 Register right_type = scratch;
231 __ JumpIfObjectType(right, right_type, right_type, HEAP_NUMBER_TYPE, 232 __ JumpIfObjectType(right, right_type, right_type, HEAP_NUMBER_TYPE,
232 &heap_number); 233 &heap_number);
233 // Comparing JS objects with <=, >= is complicated. 234 // Comparing JS objects with <=, >= is complicated.
234 __ Cmp(right_type, FIRST_SPEC_OBJECT_TYPE); 235 __ Cmp(right_type, FIRST_SPEC_OBJECT_TYPE);
235 __ B(ge, slow); 236 __ B(ge, slow);
236 // Normally here we fall through to return_equal, but undefined is 237 // Normally here we fall through to return_equal, but undefined is
(...skipping 5514 matching lines...) Expand 10 before | Expand all | Expand 10 after
5751 kStackUnwindSpace, NULL, spill_offset, 5752 kStackUnwindSpace, NULL, spill_offset,
5752 MemOperand(fp, 6 * kPointerSize), NULL); 5753 MemOperand(fp, 6 * kPointerSize), NULL);
5753 } 5754 }
5754 5755
5755 5756
5756 #undef __ 5757 #undef __
5757 5758
5758 } } // namespace v8::internal 5759 } } // namespace v8::internal
5759 5760
5760 #endif // V8_TARGET_ARCH_ARM64 5761 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698