Issue 1125773004: Pull in ASCII<->UTF16 from Chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1125773004: Pull in ASCII<->UTF16 from Chromium (Closed)

Created:
5 years, 7 months ago by scottmg

Modified:
5 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master

Target Ref:
refs/heads/master

Project:
mini_chromium

Visibility:
Public.

More Reviews

Description

Pull in ASCII<->UTF16 from Chromium R=mark@chromium.org BUG=crashpad:1

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -2 lines)			Patch
M	base/base.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/strings/string_piece.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/strings/string_util.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	base/strings/string_util.cc	View	1 chunk	+23 lines, -0 lines	1 comment	Download
M	base/strings/utf_string_conversions.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	base/strings/utf_string_conversions.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

https://codereview.chromium.org/1125773004/diff/1/base/strings/string_util.cc File base/strings/string_util.cc (right): https://codereview.chromium.org/1125773004/diff/1/base/strings/string_util.cc#newcode10 base/strings/string_util.cc:10: for (size_t i = 0; i < str.length(); ++i) ...

5 years, 7 months ago (2015-05-04 23:15:33 UTC) #1

scottmg

Hold off on this one, pending https://codereview.chromium.org/1119783005/.

5 years, 7 months ago (2015-05-05 00:30:46 UTC) #2

scottmg

5 years, 7 months ago (2015-05-05 00:48:18 UTC) #3

On 2015/05/05 00:30:46, scottmg wrote:
> Hold off on this one, pending https://codereview.chromium.org/1119783005/.

Closing this as unnecessary.

Expand Messages | Collapse Messages