Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1125723002: Correctly accept already preprocessed stack traces. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly accept already preprocessed stack traces. When we preprocess stack traces, we turn code pointer and offset to source position, and store it in place of code pointer as smi. Preprocessing stack traces is currently disabled due to issue 4065. R=jkummerow@chromium.org Committed: https://crrev.com/7f927ced51bf5b5eda746d8c92ff645ccc33231c Cr-Commit-Position: refs/heads/master@{#28213}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M src/isolate.cc View 1 6 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
5 years, 7 months ago (2015-05-04 14:10:19 UTC) #1
Jakob Kummerow
LGTM
5 years, 7 months ago (2015-05-04 14:46:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125723002/1
5 years, 7 months ago (2015-05-04 14:54:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/80)
5 years, 7 months ago (2015-05-04 14:58:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125723002/1
5 years, 7 months ago (2015-05-05 06:59:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125723002/20001
5 years, 7 months ago (2015-05-05 07:01:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 07:29:00 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 07:29:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f927ced51bf5b5eda746d8c92ff645ccc33231c
Cr-Commit-Position: refs/heads/master@{#28213}

Powered by Google App Engine
This is Rietveld 408576698